Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing clang tidy #2218

Merged
merged 4 commits into from Jun 25, 2016

Conversation

Projects
None yet
2 participants
@sithhell
Copy link
Member

commented Jun 16, 2016

This PR introduces a clang-tidy pass for circle-ci which currently checks for non nullptr uses only on changed files.
The remaining patch is to eliminate the last remaining uses of 0 over nullptr.

@sithhell sithhell added this to the 0.9.12 milestone Jun 16, 2016

@sithhell sithhell force-pushed the clang_tidy branch from cad887d to d3858f9 Jun 17, 2016

sithhell and others added some commits Jun 15, 2016

Adding basic clang-tidy checker to circle-ci
This enables modernize-use-nullptr
Making use of nullptr coherent
This patch replaces the remaining uses of 0 instead of nullptr

@hkaiser hkaiser force-pushed the clang_tidy branch from a9d7153 to 79cd3af Jun 24, 2016

@hkaiser

This comment has been minimized.

Copy link
Member

commented Jun 24, 2016

LGTM, thanks!

@hkaiser hkaiser merged commit ce26b07 into master Jun 25, 2016

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@hkaiser hkaiser deleted the clang_tidy branch Jun 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.