Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning fixes #2432

Merged
merged 2 commits into from Dec 23, 2016
Merged

Warning fixes #2432

merged 2 commits into from Dec 23, 2016

Conversation

sithhell
Copy link
Member

These patches contain a few patches that remove some warnings about invalid attributes and one about a class/struct mismatch.

@sithhell sithhell added this to the 1.0.0 milestone Dec 20, 2016
hkaiser
hkaiser approved these changes Dec 20, 2016
View reviewed changes
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hkaiser
Copy link
Member

hkaiser commented Dec 20, 2016

Please add a declaration for class HPX_EXPORT thread; in threads_fwd.hpp. That would allow to close #2429 without merging.

@hkaiser hkaiser merged commit eaf3853 into master Dec 23, 2016
@hkaiser hkaiser deleted the warning_fixes branch December 23, 2016 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaiser hkaiser hkaiser approved these changes

Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sithhell @hkaiser