New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement parallel::unique_copy. #2754

Merged
merged 8 commits into from Jul 12, 2017

Conversation

2 participants
@taeguk
Member

taeguk commented Jul 11, 2017

Check Box

  • Implementation of unique_copy.
  • Unit tests for unique_copy.
  • Benchmark codes for unique_copy.
  • Adapt to Ranges TS (#1668).
  • Benchmark with using policy.executor() instead of hpx::launch::sync in scan_partitioner. (https://gist.github.com/taeguk/36f6fadce38c85096018f4df3a91d552)
    => The parallel version is faster than the sequential version, but not satisfying.

@hkaiser hkaiser added this to the 1.1.0 milestone Jul 11, 2017

@taeguk taeguk changed the title from Implement parallel::unique_copy. to [WIP] Implement parallel::unique_copy. Jul 11, 2017

@taeguk taeguk changed the title from [WIP] Implement parallel::unique_copy. to Implement parallel::unique_copy. Jul 11, 2017

@hkaiser

This comment has been minimized.

Show comment
Hide comment
@hkaiser

hkaiser Jul 11, 2017

Member

@taeguk: so is this ready to be reviewed now?

Member

hkaiser commented Jul 11, 2017

@taeguk: so is this ready to be reviewed now?

@taeguk

This comment has been minimized.

Show comment
Hide comment
@taeguk

taeguk Jul 11, 2017

Member

@hkaiser I'm ready to be reviewed.

Member

taeguk commented Jul 11, 2017

@hkaiser I'm ready to be reviewed.

@hkaiser

Otherwise, LGTM. Thanks!

Show outdated Hide outdated hpx/parallel/algorithms/unique.hpp
Show outdated Hide outdated hpx/parallel/algorithms/unique.hpp

@hkaiser hkaiser merged commit 7e6627c into STEllAR-GROUP:master Jul 12, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment