Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some uses of begin/end, remove unnecessary includes #2764

Merged
merged 1 commit into from Jul 19, 2017
Merged

Conversation

K-ballo
Copy link
Member

@K-ballo K-ballo commented Jul 17, 2017

No description provided.

@taeguk
Copy link
Member

taeguk commented Jul 17, 2017

@K-ballo I want to know what differences there are between std::begin and hpx::util::begin for Rng
Can the usage of std::begin occur bad things?

@K-ballo
Copy link
Member Author

K-ballo commented Jul 17, 2017

I want to know what differences there are between std::begin and hpx::util::begin for Rng

@taeguk As customization points, std::begin et.al. are meant to be called unqualified from generic code. Calling util::begin(rng) is effectively equivalent to using std::begin; begin(rng).

Can the usage of std::begin occur bad things?

Yes, since it's a different lookup and produces a different set of candidates, albeit it should be a rare occurrence in practice.

Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hkaiser hkaiser merged commit 2c594f6 into master Jul 19, 2017
@hkaiser hkaiser deleted the range-fixes branch July 19, 2017 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants