Adapt MSVC C++ mode handling to VS15.5 #3061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sithhell
reviewed
Dec 9, 2017
cmake/HPX_DetectCppDialect.cmake
Outdated
| @@ -116,6 +112,9 @@ macro(hpx_detect_cpp_dialect) | |||
| hpx_info("C++ mode assumed: C++11") | |||
| endif() | |||
|
|
|||
| hpx_add_config_cond_define(_HAS_AUTO_PTR_ETC 1) | |||
| hpx_add_config_cond_define(_SILENCE_ALL_CXX17_DEPRECATION_WARNINGS) | |||
There was a problem hiding this comment.
Shouldn't this go in the HPX_WITH_CXX17 only?
cmake/HPX_DetectCppDialect.cmake
Outdated
| @@ -89,24 +89,20 @@ macro(hpx_detect_cpp_dialect) | |||
|
|
|||
| # enable enforcing a particular C++ mode | |||
| if(HPX_WITH_CXX17) | |||
| set(CXX_FLAG -std:c++latest) | |||
| hpx_add_config_cond_define(_HAS_AUTO_PTR_ETC 1) | |||
| set(CXX_FLAG -std:c++17) | |||
| hpx_info("C++ mode enforced: C++17") | |||
| elseif(HPX_WITH_CXX1Z) | |||
| set(CXX_FLAG -std:c++latest) | |||
There was a problem hiding this comment.
C++1z essentially is C++17, right?
There was a problem hiding this comment.
Well, not quite - doesn't really change anything, however.
There was a problem hiding this comment.
my point is, when the next version of MSVC is released, -std:c++latest might refer to C++2a, right?
sithhell
reviewed
Dec 11, 2017
cmake/HPX_DetectCppDialect.cmake
Outdated
| hpx_info("C++ mode enforced: C++17") | ||
| hpx_add_config_cond_define(_SILENCE_ALL_CXX17_DEPRECATION_WARNINGS) | ||
| elseif(HPX_WITH_CXX1Z) | ||
| set(CXX_FLAG -std:c++latest) |
There was a problem hiding this comment.
I am still unhappy with this. Isn't C++17 the latest and not C++1z?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.