Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing #2325 #3131

Merged
merged 1 commit into from Feb 1, 2018
Merged

Fixing #2325 #3131

merged 1 commit into from Feb 1, 2018

Conversation

sithhell
Copy link
Member

@sithhell sithhell commented Jan 30, 2018

Fixes #2325

Proposed Changes

As time went by, we can re-enable the usage of executors again. Some changes
in our code base seem to have led to this not segfaulting anymore

@sithhell sithhell added this to the 1.1.0 milestone Jan 30, 2018
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the worst of all - they just stand up and disappear - how antisocial ;-)

@taeguk
Copy link
Member

taeguk commented Jan 31, 2018

GOOD! maybe you want to refer #2325 instead of #2556 in title text and commit message.

@sithhell sithhell changed the title Fixing #2556 Fixing #2325 Jan 31, 2018
As time went by, we can re-enable the usage of executors again. Some changes
in our code base seem to have led to this not segfaulting anymore.
@msimberg msimberg mentioned this pull request Jan 31, 2018
12 tasks
@msimberg msimberg merged commit 4b7761f into master Feb 1, 2018
@hkaiser hkaiser deleted the fixing_2325 branch February 1, 2018 23:34
@msimberg msimberg mentioned this pull request Feb 2, 2018
@taeguk
Copy link
Member

taeguk commented Feb 3, 2018

hpx::launch p = hpx::launch::sync;
// if (parts & 0x7)
// p = hpx::launch::sync;
FwdIter it = hpx::util::get<0>(elem);
std::size_t size = hpx::util::get<1>(elem);
hpx::shared_future<Result1> prev = workitems.back();
auto curr = executor_traits::async_execute(
policy.executor(), f1, it, size).share();
workitems.push_back(dataflow(p, f2, prev, curr));
finalitems.push_back(dataflow(p, //olicy.executor(),
f3, it, size, prev, curr));
++parts;

if (parts & 0x7) 
    p = hpx::launch::sync;

In past days, there was the code in scan_partitioner.
It disappeared in #2556 even in the comments.
And this PR didn't apply it.

@hkaiser
Copy link
Member

hkaiser commented Feb 3, 2018

@taeguk I think this was an attempt to avoid spawning asynchronous tasks for every partition, the tasks spawned tend to be very small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants