Fix locking problems during shutdown #3209
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to test if this helps for the Windows shutdown problems, but I will still see if we can get by with the
stopped_
andterminated_
flags beingatomic<bool>
s instead (the mutex has to be locked in any case for the condition variables).Proposed Changes
Any background context you want to provide?
HPX threads can migrate between OS threads. Holding an OS mutex in an HPX thread which gets migrated to another OS thread is undefined behaviour (this is checked on Windows). For #3203 a mutex was being held while being destructed.