Remove wait or add new #3243
Closed
Remove wait or add new #3243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The thread state still exists, it just isn't necessary to store staged threads in a separate queue |
|
This looks very nice, but I'll have a closer look once the other PRs are merged and the conflicts are resolved (when the diff is a bit smaller). |
biddisco
force-pushed
the
remove_wait_or_add_new
branch
2 times, most recently
from
8444608
to
5e13a67
Compare
msimberg
force-pushed
the
remove_wait_or_add_new
branch
from
c132c82
to
fa00ffe
Compare
biddisco
force-pushed
the
remove_wait_or_add_new
branch
from
392ae56
to
3cfc1b6
Compare
biddisco
force-pushed
the
remove_wait_or_add_new
branch
from
e172a92
to
43dc2bc
Compare
biddisco
force-pushed
the
remove_wait_or_add_new
branch
from
43dc2bc
to
c00a144
Compare
This changes the context implementations to perform a lazy initialization of their respective contexts. This potentially leads to less resource usage.
…ead api With lazy creation of stacks, the staged queue is no longer needed since tsks can be created immediately and scheduled when they are ready. All executrs and calls to register_thread_nullary/etc need to are modified to remove the run_now param since it is no longer meaningful.
biddisco
force-pushed
the
remove_wait_or_add_new
branch
from
c00a144
to
4789991
Compare
|
Unfortunately, this branch has been rebased so many times in the last year that at some point, something got messed up. I'm looking at it from fresh to try to unpick what's the right code to have/use. |
|
@biddisco let's get this in asap - it's the only way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleanup of the scheduling system to remove the work_items from thread_queue and wait_or_add_new.
It relies on #3146 (lazy init) and also #3186 (remove schedulers) which ought to be merged or closed at the same time (those two PRs are included in this one).
Proposed Changes
Removes work_items and wait_or_add_new - improves performance of scheduling_loop -
Any background context you want to provide?
After this, stack reuse needs to be examined