Apex refactoring with guids #3245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Major changes: When an HPX thread is created, an apex_wrapper() call is made to create an apex::task_wrapper. That object can be updated later in the case of an annotated_function. The thread maintains a pointer to this wrapper, and passes it to the apex_wrapper calls to start/stop timers. Memory is managed by APEX, and the task_wrapper object is destroyed after apex::stop.
Removing the background thread timer because that work should be handled in the regular scheduling loop.
This should be updated to master before next release.
…ex_refactoring_with_guids
hkaiser
approved these changes
Mar 22, 2018
There was a problem hiding this comment.
LGTM, thanks!
@msimberg - not sure if you'd like to add this to the release... It is not absolutely necessary but would provide a nice addition as it keeps HPX aligned with the latest developments of APEX. It is also a low risk patch as it shouldn't influence things as long as HPX_WITH_APEX=Off.
|
All right, I'll go ahead and add this to the release. We won't really know if something breaks as rostam and pycicle have Apex off, but this looks fairly harmless. Thanks @khuck! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the APEX/HPX integration to track task dependencies, generate GUIDs within APEX for tracking tasks, and adds those GUIDs to the OTF2 trace output. The version of APEX that cmake will pull has been modified from "master" to "v2.0", a new tag in APEX representing these API changes. v2.0 is currently a "beta" release, if all goes well it will become an official release soon.