Note that cuda support requires cmake 3.9 #3497
Conversation
|
@biddisco is this enforced in the CMake files? |
biddisco
force-pushed
the
cuda_cmake_doc
branch
from
66cb967
to
f318fa3
Compare
|
Updated PR with quick check in CMake to raise minimal version if HPX_WITH_CUDA is enabled |
There was a problem hiding this comment.
IMHO conditionally setting the minimum version is a very bad idea. cmake_minimum_required does not only check the version but also affects the default value of all policies. Let's not make it harder to maintain the build system by introducing multiple CMake dialects.
I would use a separate check:
if (HPX_WITH_CUDA AND CMAKE_VERSION VERSION_LESS 3.9)
message(FATAL_ERROR "CUDA support requires at least CMake 3.9.")
endif() This solution has the additional benefit that the error message spells out the actual problem.
biddisco
force-pushed
the
cuda_cmake_doc
branch
from
f318fa3
to
c8d6aa0
Compare
|
Updated to do it using your suggestion. I was being lazy and I'm glad you didn't let me get away with it. |
| @@ -15,6 +15,10 @@ | |||
| # We require at least CMake V3.3.2 | |||
| cmake_minimum_required(VERSION 3.3.2 FATAL_ERROR) | |||
|
|
|||
| if (HPX_WITH_CUDA AND CMAKE_VERSION VERSION_LESS 3.9) | |||
There was a problem hiding this comment.
Isn't HPX_WITH_CUDA defined only further down in this file?
There was a problem hiding this comment.
yes, but the first time someone runs cmake, they will either use cmake -DHPX_WITH_CUDA on the command line, or they will run it once with ccmake then change the gui setting to enable HPX_WITH_CUDA and then when they configure, they'll get the error.
No description provided.