Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding test ensuring ticket 3565 is fixed #3572

Merged
merged 1 commit into from Dec 2, 2018
Merged

Adding test ensuring ticket 3565 is fixed #3572

merged 1 commit into from Dec 2, 2018

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Dec 1, 2018

  • flyby: make sure inheritance_2_classes_concrete test actually passes if run on one core

@bremerm31 Everything is ok, the test you created (and the similar one that was already in HPX) was flawed. Because of the non-immediate nature of deleting components by AGAS the destructor of the objects was not called before you checked. I added an explicit call to garbage_collect (enforcing deletion of all pending objects) and now everything looks fine.

This fixes #3565

- flyby: make sure inheritance_2_classes_concrete test actually passes if run on  one core
Copy link
Contributor

@biddisco biddisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hkaiser hkaiser merged commit 6feb43f into master Dec 2, 2018
@hkaiser hkaiser deleted the fixing_3565 branch December 2, 2018 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polymorphic simple component destructor not getting called
2 participants