Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify parcel creation #3631

Merged
merged 2 commits into from Feb 3, 2019
Merged

Simplify parcel creation #3631

merged 2 commits into from Feb 3, 2019

Conversation

K-ballo
Copy link
Member

@K-ballo K-ballo commented Jan 22, 2019

No description provided.

@hkaiser hkaiser added this to the 1.3.0 milestone Jan 22, 2019
hkaiser
hkaiser previously approved these changes Jan 22, 2019
View reviewed changes
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks!

biddisco
biddisco previously approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@biddisco biddisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Seems like a replacement of the action/continuation_action creation and doesn't change anything else - Can someone remind me what the significance of these types are in the parcel creation step? I've forgotten what they are for.

hkaiser
hkaiser approved these changes Feb 2, 2019
View reviewed changes
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@sithhell sithhell merged commit 826f4ea into master Feb 3, 2019
@hkaiser hkaiser deleted the put_parcel-light branch February 3, 2019 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaiser hkaiser hkaiser approved these changes

@biddisco biddisco biddisco left review comments

Assignees
No one assigned
Labels
category: parcel transport type: enhancement
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@K-ballo @hkaiser @biddisco @sithhell