Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing CUDA compiler errors #3702

Closed
wants to merge 5 commits into from
Closed

Fixing CUDA compiler errors #3702

wants to merge 5 commits into from

Conversation

sithhell
Copy link
Member

The current CUDA builds are broken. This is an attempt to fix this...

@hkaiser hkaiser added this to the 1.3.0 milestone Feb 16, 2019
@msimberg
Copy link
Contributor

@sithhell should we add -Wno-noexcept-type to take care of the errors pycicle is reporting? They are benign as far as I can tell, as long as one doesn't mix C++11/14 and 17 code...

@sithhell
Copy link
Member Author

@sithhell should we add -Wno-noexcept-type to take care of the errors pycicle is reporting? They are benign as far as I can tell, as long as one doesn't mix C++11/14 and 17 code...

or we remove the 'throw ()' functions?

@msimberg
Copy link
Contributor

msimberg commented Feb 18, 2019 via email

@hkaiser
Copy link
Member

hkaiser commented Apr 7, 2019

@sithhell should we add -Wno-noexcept-type to take care of the errors pycicle is reporting? They are benign as far as I can tell, as long as one doesn't mix C++11/14 and 17 code...

or we remove the 'throw ()' functions?

Yes, we should be able to safely replace those with noexcept nowadays. I'd suggest to solve this in a separate PR, however (see #3778).

@hkaiser hkaiser marked this pull request as ready for review April 7, 2019 14:29
@hkaiser
Copy link
Member

hkaiser commented Apr 7, 2019

@msimberg, @sithhell: I addressed the review comments, let's get this merged asap to get the CUDA builders under control.

@hkaiser hkaiser closed this Apr 7, 2019
@hkaiser hkaiser reopened this Apr 7, 2019
@hkaiser
Copy link
Member

hkaiser commented Apr 8, 2019

I have manually merged this as GitHub refused to merge it through the web interface. Closing...

@hkaiser hkaiser closed this Apr 8, 2019
@hkaiser hkaiser deleted the fix_cuda branch April 8, 2019 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaiser hkaiser hkaiser left review comments

Assignees
No one assigned
Labels
category: CMake platform: CUDA type: enhancement
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sithhell @msimberg @hkaiser