Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding all_reduce facility to collectives module #3950

Merged
merged 3 commits into from Jul 5, 2019
Merged

Adding all_reduce facility to collectives module #3950

merged 3 commits into from Jul 5, 2019

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Jul 1, 2019

  • flyby: minor fixes to all_to_all

@hkaiser hkaiser added this to the 1.4.0 milestone Jul 1, 2019
@hkaiser hkaiser added this to TODO in HPX modularization via automation Jul 1, 2019
@hkaiser
Adding all_reduce facility to collectives module
3da34a5 
- flyby: minor fixes to all_to_all
@hkaiser
Streamline all_to_all implementation
ba73c8a 
- flyby: fix possible bug in all_to_all
@hkaiser
Copy link
Member Author

hkaiser commented Jul 4, 2019

@msimberg this is good to go now. Would you have the time to review?

msimberg
msimberg approved these changes Jul 5, 2019
View reviewed changes
Copy link
Contributor

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible to me. Thanks @hkaiser!

libs/collectives/include/hpx/collectives/all_reduce.hpp Show resolved Hide resolved
HPX modularization automation moved this from TODO to In Progress Jul 5, 2019
@hkaiser hkaiser merged commit ea0b442 into master Jul 5, 2019
HPX modularization automation moved this from In Progress to Done Jul 5, 2019
@hkaiser hkaiser deleted the all_reduce branch July 5, 2019 15:02
@sithhell sithhell mentioned this pull request Aug 8, 2019
Closed
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msimberg msimberg msimberg approved these changes

Assignees
No one assigned
Labels
category: LCOs category: modules type: enhancement
Projects
HPX modularization
  
Done
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hkaiser @msimberg