Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete apex.hpp #4285

Merged
merged 1 commit into from Dec 20, 2019
Merged

Delete apex.hpp #4285

merged 1 commit into from Dec 20, 2019

Conversation

@msimberg
Copy link
Contributor

msimberg commented Dec 19, 2019

The file is unused and has been replaced by external_timer.hpp

The file is unused and has been replaced by external_timer.hpp
Copy link
Member

hkaiser left a comment

I'd assume that the test failure on the APEX builder is unrelated. LGTM, thanks!

@msimberg

This comment has been minimized.

Copy link
Contributor Author

msimberg commented Dec 20, 2019

It is indeed unrelated. It looks like it's a pretty reproducible failure, but I haven't had the time to look into it.

@msimberg msimberg merged commit fe37ef4 into master Dec 20, 2019
15 of 16 checks passed
15 of 16 checks passed
pycicle daint-clang-apex Test errors 1
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
build-and-test Workflow: build-and-test
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pycicle daint-clang-apex Build errors 0
Details
pycicle daint-clang-apex Config errors 0
Details
pycicle daint-clang-newest Build errors 0
Details
pycicle daint-clang-newest Config errors 0
Details
pycicle daint-clang-newest Test errors 0
Details
pycicle daint-gcc-newest Build errors 0
Details
pycicle daint-gcc-newest Config errors 0
Details
pycicle daint-gcc-newest Test errors 0
Details
pycicle daint-gcc-oldest Build errors 0
Details
pycicle daint-gcc-oldest Config errors 0
Details
pycicle daint-gcc-oldest Test errors 0
Details
@msimberg msimberg added this to the 1.4.0 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.