Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete apex.hpp #4285

Merged
merged 1 commit into from Dec 20, 2019
Merged

Delete apex.hpp #4285

merged 1 commit into from Dec 20, 2019

Conversation

msimberg
Copy link
Contributor

The file is unused and has been replaced by external_timer.hpp

@msimberg
Delete apex.hpp
2717bc6 
The file is unused and has been replaced by external_timer.hpp
hkaiser
hkaiser approved these changes Dec 20, 2019
View reviewed changes
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd assume that the test failure on the APEX builder is unrelated. LGTM, thanks!

@msimberg
Copy link
Contributor Author

It is indeed unrelated. It looks like it's a pretty reproducible failure, but I haven't had the time to look into it.

@msimberg msimberg merged commit fe37ef4 into master Dec 20, 2019
@msimberg msimberg added this to the 1.4.0 milestone Jan 6, 2020
@hkaiser hkaiser deleted the msimberg-patch-2 branch June 21, 2020 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaiser hkaiser hkaiser approved these changes

Assignees
No one assigned
Labels
category: APEX
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@msimberg @hkaiser