Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows and macOS CI with GitHub actions #4379

Merged
merged 5 commits into from Feb 17, 2020

Conversation

msimberg
Copy link
Contributor

Currently builds all tests, examples, etc. on macOS (and runs the tests). On Windows it only builds and runs the examples because of broken pseudo-dependencies.

This also fixes compilation of some more examples. I will cherry-pick those onto the release branch.

Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks!

@msimberg
Copy link
Contributor Author

Btw, the latest builds are here: macOS and Windows. In the previous round the macOS tests were pretty good (meaning around 10 failed tests). Some were affinity related and some not. On the Windows builder there are apparently only 2 PUs available, hence the new option HPX_WITH_TESTS_MAX_THREADS_PER_LOCALITY. The build is still running so not sure if it works yet.

@msimberg
Copy link
Contributor Author

I'm also hoping that the status checks will start showing up once this is merged. If not I'll look into them separately.

@msimberg
Copy link
Contributor Author

@hkaiser do any of these test failures look like something we would expect on Windows under normal conditions: https://github.com/msimberg/hpx/runs/444043594?check_suite_focus=true#step:6:8? Or would you guess that these are caused by limitations of running on a VM?

@hkaiser
Copy link
Member

hkaiser commented Feb 14, 2020

do any of these test failures look like something we would expect on Windows under normal conditions: https://github.com/msimberg/hpx/runs/444043594?check_suite_focus=true#step:6:8? Or would you guess that these are caused by limitations of running on a VM?

Frankly, I don't know what could have caused this.

@msimberg
Copy link
Contributor Author

do any of these test failures look like something we would expect on Windows under normal conditions: https://github.com/msimberg/hpx/runs/444043594?check_suite_focus=true#step:6:8? Or would you guess that these are caused by limitations of running on a VM?

Frankly, I don't know what could have caused this.

No worries, then we'll live with them for now. I may add a blacklist of examples that we know fail to not miss newly introduced failures. I think the most important thing is that we at least build all the examples now.

@msimberg
Copy link
Contributor Author

I'll merge this now and keep iterating once I see how it works on master.

@msimberg msimberg merged commit 8f5487b into STEllAR-GROUP:master Feb 17, 2020
@msimberg msimberg deleted the gh-actions branch February 17, 2020 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants