Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning messages for using thread binding options on macOS #4386

Merged
merged 1 commit into from Feb 17, 2020
Merged

Add warning messages for using thread binding options on macOS #4386

merged 1 commit into from Feb 17, 2020

Conversation

msimberg
Copy link
Contributor

Attempt to fix #4349. @albestro would you mind testing the changes?

@msimberg msimberg added this to the 1.5.0 milestone Feb 13, 2020
hkaiser
hkaiser previously approved these changes Feb 13, 2020
View reviewed changes
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

albestro
albestro previously approved these changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@albestro albestro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @msimberg !

I just tried on my use-case: it correctly prints the warning message and it let run the program without errors.

Before merging, you have to correct the preprocessor directive (see my comment).

@msimberg msimberg dismissed stale reviews from albestro and hkaiser via 69eb729 February 14, 2020 12:01
@msimberg
Copy link
Contributor Author

Thanks @albestro for testing! I've fixed the issues you found. Do the messages themselves seem clear enough for you?

@albestro
Copy link
Contributor

Yeah, it looks perfect!
Thank you again!

@msimberg msimberg merged commit afeda00 into STEllAR-GROUP:master Feb 17, 2020
@msimberg msimberg deleted the thread-binding-warning branch February 17, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albestro albestro albestro left review comments

@hkaiser hkaiser hkaiser left review comments

Assignees
No one assigned
Labels
category: affinity platform: Mac OSX
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

--hpx:use-process-mask option throw an exception on OS X
3 participants
@msimberg @albestro @hkaiser