Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing sub-name sequencing for experimental namespace #4525

Closed
wants to merge 1 commit into from

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Apr 15, 2020

This change will simplify pulling things from the experimental namespace into the main namespace down the road as it makes different things in the experimental namespace more granular. I.e. if we at some point want to start the process of moving the facilities that are now in namespace hpx::experimental::mpi into the main namespace, this can be easiliy done with:

#if defined(HPX_EXPERIMENTAL_MPI_COMPATIBILITY
namespace hpx { namespace mpi {
    using namespace hpx::experimental::mpi;
}}
#endif

This wouldn't be possible with the current naming scheme.

@hkaiser
Copy link
Member Author

hkaiser commented Apr 16, 2020

After walking around the block I'm not sure anymore what I was thinking. The current scheme is perfectly fine and can be used in a similar way as outlined above. Closing...

@hkaiser hkaiser closed this Apr 16, 2020
@hkaiser hkaiser deleted the experimental_namespace branch April 16, 2020 01:01
@msimberg
Copy link
Contributor

You had me thinking real hard with this one. That said, if someone thinks that hpx::experimental::mpi actually feels better than hpx::mpi::experimental I think we can go with that as well. The argument for the latter is mostly for consistency with detail, but that doesn't need to stay that way either...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants