Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding some explanation to README about how to cite HPX #4941

Merged
merged 2 commits into from Sep 3, 2020
Merged

Adding some explanation to README about how to cite HPX #4941

merged 2 commits into from Sep 3, 2020

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Sep 3, 2020

No description provided.

@hkaiser hkaiser added this to the 1.6.0 milestone Sep 3, 2020
hkaiser
hkaiser commented Sep 3, 2020
View reviewed changes
README.rst Outdated Show resolved Hide resolved
msimberg
msimberg previously approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hkaiser! Did you mean to review your own PR? Or is it a question about whether we prefer publication or paper?

@hkaiser
Copy link
Member Author

hkaiser commented Sep 3, 2020

Thanks @hkaiser! Did you mean to review your own PR? Or is it a question about whether we prefer publication or paper?

I noticed using the word 'publication' twice and I was too lazy to re-commit, so I went in and added a review comment here ;-)

diehlpk
diehlpk approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@diehlpk diehlpk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hkaiser hkaiser merged commit 8bf0a6d into master Sep 3, 2020
@hkaiser hkaiser deleted the citations branch September 3, 2020 20:53
@aurianer
Copy link
Contributor

aurianer commented Sep 4, 2020

Thanks!

@aurianer aurianer modified the milestones: 1.6.0, 1.5.1 Sep 29, 2020
@aurianer aurianer mentioned this pull request Sep 29, 2020
Closed
aurianer pushed a commit that referenced this pull request Sep 29, 2020
@hkaiser @aurianer
Merge pull request #4941 from STEllAR-GROUP/citations
53aecb9 
Adding some explanation to README about how to cite HPX
aurianer pushed a commit that referenced this pull request Sep 29, 2020
@hkaiser @aurianer
Merge pull request #4941 from STEllAR-GROUP/citations
77fa16c 
Adding some explanation to README about how to cite HPX
aurianer pushed a commit that referenced this pull request Sep 30, 2020
@hkaiser @aurianer
Merge pull request #4941 from STEllAR-GROUP/citations
aef9a4d 
Adding some explanation to README about how to cite HPX
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diehlpk diehlpk diehlpk approved these changes

@msimberg msimberg msimberg left review comments

@aurianer aurianer Awaiting requested review from aurianer

@biddisco biddisco Awaiting requested review from biddisco

Assignees
No one assigned
Labels
category: documentation type: enhancement
Projects
None yet
Milestone
1.5.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hkaiser @aurianer @msimberg @diehlpk