Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing some warnings from HPX complaining about use of obsolete types #4990

Merged
merged 1 commit into from Oct 2, 2020

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Sep 30, 2020

There are probably more warnings caused by the recent enabling of the deprecation macros. The changes in this PR make Phylanx compile without those.

@msimberg
Copy link
Contributor

Thanks @hkaiser for fixing these. Any idea why these wouldn't have been triggered earlier? Or did I just not notice before merging?

@hkaiser
Copy link
Member Author

hkaiser commented Sep 30, 2020

Thanks @hkaiser for fixing these. Any idea why these wouldn't have been triggered earlier? Or did I just not notice before merging?

I have no idea. Also I'm sure that there are more of those. Especially the use of execution::is_sequenced_execution_policy by various algorithm implementations. I have not had the time to do a thorough check for those, however.

@msimberg
Copy link
Contributor

msimberg commented Sep 30, 2020

Thanks @hkaiser for fixing these. Any idea why these wouldn't have been triggered earlier? Or did I just not notice before merging?

I have no idea. Also I'm sure that there are more of those. Especially the use of execution::is_sequenced_execution_policy by various algorithm implementations. I have not had the time to do a thorough check for those, however.

You (or whoever found these) are not using gcc by any chance (edit: I suppose MSVC might warn about them?)? It looks to me like clang doesn't warn about deprecated alias templates: https://godbolt.org/z/o7dYd5. I shall be enabling deprecation warnings on other builders as well (it's only enabled on CircleCI now).

@hkaiser
Copy link
Member Author

hkaiser commented Sep 30, 2020

You (or whoever found these) are not using gcc by any chance (edit: I suppose MSVC might warn about them?)? It looks to me like clang doesn't warn about deprecated alias templates: https://godbolt.org/z/o7dYd5. I shall be enabling deprecation warnings on other builders as well (it's only enabled on CircleCI now).

These warnings were produced by MSVC.

Copy link
Contributor

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me except for the clang formatting changes reported by CircleCI.

aurianer
aurianer previously approved these changes Oct 1, 2020
Copy link
Contributor

@aurianer aurianer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@hkaiser
Copy link
Member Author

hkaiser commented Oct 1, 2020

Thanks! Looks good to me except for the clang formatting changes reported by CircleCI.

Different version of clang-format again sigh. I'll fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants