New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing some warnings from HPX complaining about use of obsolete types #4990
Conversation
c03f04a
to
5cb20b3
Compare
Thanks @hkaiser for fixing these. Any idea why these wouldn't have been triggered earlier? Or did I just not notice before merging? |
I have no idea. Also I'm sure that there are more of those. Especially the use of |
You (or whoever found these) are not using gcc by any chance (edit: I suppose MSVC might warn about them?)? It looks to me like clang doesn't warn about deprecated alias templates: https://godbolt.org/z/o7dYd5. I shall be enabling deprecation warnings on other builders as well (it's only enabled on CircleCI now). |
These warnings were produced by MSVC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good to me except for the clang formatting changes reported by CircleCI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
Different version of clang-format again sigh. I'll fix it. |
5cb20b3
to
2a5500e
Compare
There are probably more warnings caused by the recent enabling of the deprecation macros. The changes in this PR make Phylanx compile without those.