Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unused variable warnings #5057

Merged

Conversation

msimberg
Copy link
Contributor

Fixes warnings in the core library, but not tests/examples (the warning flags are now added to the header tests). Still a bit of cleanup and sanity checking to do...

@msimberg msimberg added this to the 1.6.0 milestone Nov 19, 2020
hkaiser
hkaiser previously approved these changes Nov 19, 2020
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thanks!

@msimberg msimberg force-pushed the fix-unused-variable-warnings branch 11 times, most recently from cdd4be5 to 5b2d45c Compare November 26, 2020 14:29
@msimberg msimberg force-pushed the fix-unused-variable-warnings branch 6 times, most recently from 2232b78 to ad59f96 Compare November 27, 2020 16:14
@msimberg msimberg marked this pull request as ready for review November 30, 2020 09:51
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@msimberg msimberg merged commit e9d1808 into STEllAR-GROUP:master Dec 1, 2020
@msimberg msimberg deleted the fix-unused-variable-warnings branch December 1, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants