Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow logging when distributed runtime is off #5155

Merged

Conversation

msimberg
Copy link
Contributor

@msimberg msimberg commented Feb 8, 2021

Fixes #4566.

@msimberg msimberg added this to the 1.7.0 milestone Feb 8, 2021
hkaiser
hkaiser previously approved these changes Feb 8, 2021
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thanks!

@msimberg
Copy link
Contributor Author

msimberg commented Feb 9, 2021

I additionally moved the init_logging files to the init_runtime module (without a compatibility header). I think that's an appropriate place for the functionality.

@msimberg msimberg force-pushed the enable-logging-distributed-off branch from 270409b to e6f8ce6 Compare February 10, 2021 11:33
@msimberg msimberg marked this pull request as ready for review February 11, 2021 09:24
@msimberg msimberg force-pushed the enable-logging-distributed-off branch 2 times, most recently from 2254701 to ef0bfa7 Compare February 15, 2021 11:20
@msimberg msimberg force-pushed the enable-logging-distributed-off branch from ef0bfa7 to 1e04a2b Compare February 15, 2021 12:03
@msimberg msimberg merged commit fea5ebe into STEllAR-GROUP:master Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make logging work with local runtime
2 participants