Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only find Boost.Iostreams if required for plugins #5233

Merged
merged 1 commit into from Mar 24, 2021
Merged

Only find Boost.Iostreams if required for plugins #5233

merged 1 commit into from Mar 24, 2021

Conversation

msimberg
Copy link
Contributor

No description provided.

@msimberg msimberg added this to the 1.7.0 milestone Mar 10, 2021
hkaiser
hkaiser reviewed Mar 10, 2021
View reviewed changes
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need Boost.Iostreams for our iostream component as well?

@msimberg
Copy link
Contributor Author

Don't we need Boost.Iostreams for our iostream component as well?

Good question. Apparently not given that it hasn't been linked so far. It does need the headers, but it'd be better to link explicitly to the Boost::iostreams since it's mostly luck if the headers were enough. I'll change that.

hkaiser
hkaiser previously approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

aurianer
aurianer previously approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@aurianer aurianer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@msimberg msimberg marked this pull request as draft March 11, 2021 09:06
@msimberg msimberg dismissed stale reviews from aurianer and hkaiser via 729f3ed March 22, 2021 11:50
@msimberg
Copy link
Contributor Author

Don't we need Boost.Iostreams for our iostream component as well?

Good question. Apparently not given that it hasn't been linked so far. It does need the headers, but it'd be better to link explicitly to the Boost::iostreams since it's mostly luck if the headers were enough. I'll change that.

I changed my mind on this. Given that iostreams pulls in an unnecessary regex dependency, and they document which headers can be used with header-only boost (https://www.boost.org/doc/libs/1_75_0/libs/iostreams/doc/index.html), I think it's ok to not link to the iostreams library. I take back my statement that it worked mostly through luck...

@msimberg msimberg marked this pull request as ready for review March 22, 2021 11:53
@msimberg msimberg merged commit 882adfd into STEllAR-GROUP:master Mar 24, 2021
@msimberg msimberg deleted the boost-iostreams branch March 24, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaiser hkaiser hkaiser left review comments

@aurianer aurianer aurianer left review comments

@biddisco biddisco Awaiting requested review from biddisco

Assignees
No one assigned
Labels
category: boost category: CMake type: cleanup
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@msimberg @hkaiser @aurianer