Add back explicit -pthread flags when available #5437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will be the last regular PR (I'm not counting #5417) for 1.7.0 unless there's a really critical regression or bug that still pops up. |
@msimberg No problem. My builds succeeded. Your updates seem fine. |
|
retest cscs |
msimberg
force-pushed
the
fix-pthreads-cray-clang
branch
from
037d6fc
to
3dfcb74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that we do actually need the
-pthreadflag when using the Cray compiler, so I'm adding it back here for both compilation and linking (#5420 is responsible for the timeouts on the clang-cuda configuration and I missed this before merging). The flag also now gets passed on to consuming projects unlike before #5420.@kordejong I know you may be tired of rebuilding HPX, but if you have the time I'd be very grateful if you could also test this on your system to ensure that I haven't brought things back to before #5420...