Adapt partition, partition_copy and stable_partition to C++ 20 #5540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jedi18
requested review from
aurianer,
biddisco,
hkaiser and
msimberg
as code owners
Jedi18
force-pushed
the
adapt_partition
branch
2 times, most recently
from
07e6066
to
8d3c586
Compare
hkaiser
reviewed
Sep 8, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/partition.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Sep 8, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/partition.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Sep 8, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/partition.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Sep 8, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/partition.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Sep 8, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/partition.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Sep 8, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/partition.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Sep 8, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/partition.hpp
Outdated
Show resolved
Hide resolved
Jedi18
force-pushed
the
adapt_partition
branch
3 times, most recently
from
37e6c3d
to
d0d267d
Compare
Jedi18
commented
Sep 15, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/partition.hpp
Outdated
Show resolved
Hide resolved
Jedi18
commented
Sep 15, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/detail/advance_and_get_distance.hpp
Outdated
Show resolved
Hide resolved
hkaiser
previously approved these changes
Sep 17, 2021
Yes I probably shouldn't have done that in this PR, especially given the restructuring done on the master. I'll try and remove those changes. |
Jedi18
force-pushed
the
adapt_partition
branch
from
d0d267d
to
b852d7a
Compare
… and partition_copy
Jedi18
force-pushed
the
adapt_partition
branch
from
b852d7a
to
a246d61
Compare
This was referenced Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted partition, partition_copy and stable_partition to C++ 20 and added container overloads. (range and sentinel). Added container tests for stable_partition.
Any background context you want to provide?
Issue #4822
Issue #3646
Issue #1668