Add nth_element #5592
Merged
Add nth_element #5592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jedi18
requested review from
aurianer,
biddisco,
hkaiser and
msimberg
as code owners
Jedi18
force-pushed
the
add_nth_element
branch
5 times, most recently
from
7a9812c
to
82dda33
Compare
Jedi18
force-pushed
the
add_nth_element
branch
2 times, most recently
from
c9b44ec
to
ada2c3b
Compare
hkaiser
reviewed
Oct 5, 2021
libs/core/algorithms/include/hpx/parallel/algorithms/nth_element.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Oct 5, 2021
libs/core/algorithms/include/hpx/parallel/algorithms/nth_element.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Oct 5, 2021
libs/core/algorithms/include/hpx/parallel/algorithms/nth_element.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Oct 5, 2021
libs/core/algorithms/include/hpx/parallel/algorithms/nth_element.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Oct 5, 2021
libs/core/algorithms/include/hpx/parallel/algorithms/nth_element.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Oct 5, 2021
libs/core/algorithms/include/hpx/parallel/algorithms/nth_element.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Oct 5, 2021
libs/core/algorithms/include/hpx/parallel/algorithms/nth_element.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Oct 5, 2021
libs/core/algorithms/include/hpx/parallel/container_algorithms/nth_element.hpp
Show resolved
Hide resolved
Jedi18
force-pushed
the
add_nth_element
branch
from
ada2c3b
to
c438944
Compare
…l in nth_element parallel implementation
Jedi18
force-pushed
the
add_nth_element
branch
from
c438944
to
156afac
Compare
hkaiser
reviewed
Oct 6, 2021
Jedi18
force-pushed
the
add_nth_element
branch
from
5e85690
to
2d01bcb
Compare
hkaiser
reviewed
Oct 8, 2021
libs/core/executors/include/hpx/executors/datapar/execution_policy.hpp
Outdated
Show resolved
Hide resolved
Jedi18
force-pushed
the
add_nth_element
branch
from
2d01bcb
to
f808100
Compare
|
This PR should be ready. Also I'm not able to locally reproduce the unique test failure (not related to this PR). |
hkaiser
reviewed
Oct 9, 2021
libs/core/algorithms/include/hpx/parallel/container_algorithms/nth_element.hpp
Outdated
Show resolved
Hide resolved
Jedi18
force-pushed
the
add_nth_element
branch
from
654d587
to
873c707
Compare
This was referenced Oct 9, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @fjtapia for his sequential nth_element implementation.
Added tag_fallback_dispatch overloads for parallel and container overloads. Added normal and range tests.
Added simple parallel nth_element implementation (till Francisco works on his parallel implementation)
Any background context you want to provide?
Issue #4822
Issue #3646
Issue #1668