Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add matrix multiplication example #5645

Merged
merged 1 commit into from Dec 10, 2021
Merged

Add matrix multiplication example #5645

merged 1 commit into from Dec 10, 2021

Conversation

dimitraka
Copy link
Contributor

@dimitraka dimitraka commented Nov 11, 2021 •
edited

Proposed Changes

  • matrix multiplication example
  • matrix multiplication explanation

@msimberg msimberg added the split: docs PR targets documentation label Nov 15, 2021
msimberg
msimberg requested changes Nov 16, 2021
View reviewed changes
docs/sphinx/examples.rst Outdated Show resolved Hide resolved
docs/sphinx/examples/matrix_multiplication.rst Show resolved Hide resolved
docs/sphinx/examples/matrix_multiplication.rst Outdated Show resolved Hide resolved
docs/sphinx/examples/matrix_multiplication.rst Outdated Show resolved Hide resolved
docs/sphinx/examples/matrix_multiplication.rst Outdated Show resolved Hide resolved
examples/quickstart/matrix_multiplication.cpp Outdated Show resolved Hide resolved
examples/quickstart/matrix_multiplication.cpp Outdated Show resolved Hide resolved
examples/quickstart/matrix_multiplication.cpp Outdated Show resolved Hide resolved
docs/sphinx/examples/matrix_multiplication.rst Show resolved Hide resolved
examples/quickstart/matrix_multiplication.cpp Outdated Show resolved Hide resolved
msimberg
msimberg requested changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. Just a few minor changes still needed. Thanks!

docs/sphinx/examples/matrix_multiplication.rst Outdated Show resolved Hide resolved
examples/quickstart/matrix_multiplication.cpp Show resolved Hide resolved
examples/quickstart/matrix_multiplication.cpp Outdated Show resolved Hide resolved
examples/quickstart/matrix_multiplication.cpp Outdated Show resolved Hide resolved
@dimitraka dimitraka force-pushed the sphinx_theme branch 2 times, most recently from 3c059ca to cd3e6f6 Compare December 1, 2021 16:04
msimberg
msimberg requested changes Dec 9, 2021
View reviewed changes
examples/quickstart/matrix_multiplication.cpp Outdated Show resolved Hide resolved
docs/sphinx/examples/matrix_multiplication.rst Outdated Show resolved Hide resolved
examples/quickstart/matrix_multiplication.cpp Outdated Show resolved Hide resolved
examples/quickstart/matrix_multiplication.cpp Outdated Show resolved Hide resolved
@StellarBot
Copy link

Performance test report

HPX Performance

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch-

Info

PropertyBeforeAfter
HPX Datetime2021-11-11T08:14:57+00:002021-12-09T16:55:42+00:00
HPX Commit96a2e4b76bb684
Datetime2021-11-11T09:28:13.071121+01:002021-12-09T18:27:01.519293+01:00
Hostnamenid00006nid00101
Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Envfile
Clusternamedaintdaint

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add(=)(=)(=)
Stream Benchmark - Scale(=)(=)(=)
Stream Benchmark - Triad=(=)(=)
Stream Benchmark - Copy(=)(=)(=)

Info

PropertyBeforeAfter
HPX Datetime2021-11-10T19:14:21+00:002021-12-09T16:55:42+00:00
HPX Commit71d8dbe76bb684
Datetime2021-11-10T20:28:18.266961+01:002021-12-09T18:27:17.163017+01:00
Hostnamenid00120nid00101
Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Envfile
Clusternamedaintdaint

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

msimberg
msimberg approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dimitraka for this work! Now let's merge it.

@msimberg
Copy link
Contributor

bors merge

@bors
Copy link

bors bot commented Dec 10, 2021

Build succeeded:

@bors bors bot merged commit b29d4b6 into STEllAR-GROUP:master Dec 10, 2021
@gonidelis gonidelis added this to the 1.8.0 milestone Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msimberg msimberg msimberg approved these changes

@aurianer aurianer Awaiting requested review from aurianer

@biddisco biddisco Awaiting requested review from biddisco

@hkaiser hkaiser Awaiting requested review from hkaiser hkaiser is a code owner

Assignees
No one assigned
Labels
category: examples split: docs PR targets documentation
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dimitraka @StellarBot @msimberg @aurianer @gonidelis