Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tagged, tagged_pair and tagged_tuple, remove tuple/pair specializations #5657

Merged
merged 3 commits into from Nov 18, 2021

Conversation

Jedi18
Copy link
Contributor

@Jedi18 Jedi18 commented Nov 16, 2021

Fixes #5652

Proposed Changes

  • Remove tagged, tagged_pair and tagged_tuple (and related tests)
  • Change partition_copy and sort_by_key to use appropriate return types instead of tagged_tuple and tagged_pair
  • Remove tuple/pair specializations from local_algorithm_result and algorithm_result_helper

@StellarBot
Copy link

Performance test report

HPX Performance

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch(=)

Info

PropertyBeforeAfter
HPX Datetime2021-11-11T08:14:57+00:002021-11-17T05:19:21+00:00
HPX Commit96a2e4b2397a6e
Datetime2021-11-11T09:28:13.071121+01:002021-11-17T06:33:14.287827+01:00
Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Clusternamedaintdaint
Hostnamenid00006nid00101
Envfile

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add-(=)(=)
Stream Benchmark - Scale(=)(=)(=)
Stream Benchmark - Triad(=)(=)(=)
Stream Benchmark - Copy(=)=(=)

Info

PropertyBeforeAfter
HPX Datetime2021-11-10T19:14:21+00:002021-11-17T05:19:21+00:00
HPX Commit71d8dbe2397a6e
Datetime2021-11-10T20:28:18.266961+01:002021-11-17T06:33:29.760387+01:00
Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Clusternamedaintdaint
Hostnamenid00120nid00101
Envfile

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@msimberg msimberg added split: distributed PR targets distributed functionality split: local PR targets local functionality labels Nov 17, 2021
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hkaiser
Copy link
Member

hkaiser commented Nov 17, 2021

bors merge

@bors
Copy link

bors bot commented Nov 18, 2021

Build succeeded:

@bors bors bot merged commit 9dda063 into STEllAR-GROUP:master Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove tuple/pair specializations for local_algorithm_result and friends
4 participants