New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove tagged, tagged_pair and tagged_tuple, remove tuple/pair specializations #5657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…helper and local_algorithm_result
Jedi18
requested review from
aurianer,
biddisco,
hkaiser and
msimberg
as code owners
November 16, 2021 15:20
Jedi18
force-pushed
the
remove_tuple_pair_spec
branch
from
November 16, 2021 15:24
9471240
to
2ebe7b7
Compare
hkaiser
reviewed
Nov 16, 2021
hkaiser
reviewed
Nov 16, 2021
libs/core/algorithms/include/hpx/parallel/algorithms/sort_by_key.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Nov 16, 2021
libs/full/segmented_algorithms/include/hpx/parallel/segmented_algorithms/detail/dispatch.hpp
Show resolved
Hide resolved
Jedi18
force-pushed
the
remove_tuple_pair_spec
branch
from
November 17, 2021 03:12
7b077c0
to
93a424b
Compare
Jedi18
force-pushed
the
remove_tuple_pair_spec
branch
from
November 17, 2021 05:19
93a424b
to
1bdaccb
Compare
Performance test reportHPX PerformanceComparison
Info
Comparison
Info
Explanation of Symbols
|
msimberg
added
split: distributed
PR targets distributed functionality
split: local
PR targets local functionality
labels
Nov 17, 2021
hkaiser
approved these changes
Nov 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
bors merge |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category: algorithms
split: distributed
PR targets distributed functionality
split: local
PR targets local functionality
type: cleanup
type: compatibility issue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5652
Proposed Changes