Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing static linking (for Windows) #5951

Merged
merged 1 commit into from Jul 15, 2022
Merged

Fixing static linking (for Windows) #5951

merged 1 commit into from Jul 15, 2022

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Jul 11, 2022

  • add github actions
  • flyby: unify handling of excluded targets for Windows github builders

potentially resolves #5908

@StellarBot
Copy link

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)=(=)

Info

PropertyBeforeAfter
HPX Commitd5655f8b331b48
HPX Datetime2022-05-31T12:57:29+00:002022-07-11T23:05:45+00:00
Envfile
Hostnamenid01193nid00788
Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Datetime2022-05-31T15:13:01.357969+02:002022-07-12T01:21:29.162911+02:00
Clusternamedaintdaint

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch-

Info

PropertyBeforeAfter
HPX Commitd5655f8b331b48
HPX Datetime2022-05-31T12:57:29+00:002022-07-11T23:05:45+00:00
Envfile
Hostnamenid01193nid00788
Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Datetime2022-05-31T15:13:18.026239+02:002022-07-12T01:21:46.297456+02:00
Clusternamedaintdaint

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add(=)(=)(=)
Stream Benchmark - Scale(=)(=)(=)
Stream Benchmark - Triad(=)(=)(=)
Stream Benchmark - Copy(=)(=)(=)

Info

PropertyBeforeAfter
HPX Commit71d8dbeb331b48
HPX Datetime2021-11-10T19:14:21+00:002022-07-11T23:05:45+00:00
Envfile
Hostnamenid00120nid00788
Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Datetime2021-11-10T20:28:18.266961+01:002022-07-12T01:22:01.494497+02:00
Clusternamedaintdaint

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@hkaiser hkaiser force-pushed the static_linking branch 12 times, most recently from 2d5458a to d71de6a Compare July 12, 2022 21:37
- add github action
- flyby: unify handling of excluded targets for Windows github builders
- flyby: fixing a couple of signed/unsigned and integer size related warnings
@hkaiser
Copy link
Member Author

hkaiser commented Jul 13, 2022

@Neumann-A: would you have the time to verify if this PR solves the problems you reported? Please note that I have added a github action CI that builds HPX using static linking on Windows.

@hkaiser hkaiser modified the milestones: 1.9.0, 1.8.1 Jul 15, 2022
@hkaiser
Copy link
Member Author

hkaiser commented Jul 15, 2022

bors merge

@bors
Copy link

bors bot commented Jul 15, 2022

Build succeeded:

@bors bors bot merged commit 3febca3 into master Jul 15, 2022
@bors bors bot deleted the static_linking branch July 15, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows: duplicated symbols in static builds
2 participants