Fix segmented algorithms tests

[Pansysk75]

Fixes a group of tests for HPX segmented algorithms, which were occasionally failing due to improper initialization of partitioned_vector. Initialization using partitioned_vector::set_value() is asynchronous and returns a future, but we never waited for it to complete.

[jenkins-cscs]

Can one of the admins verify this patch?

[StellarBot]

Performance test report

HPX Performance

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
For Each	=	---	(=)

Info

Property	Before	After
HPX Commit	6b6e1e7	95f5b31
HPX Datetime	2023-03-06T15:59:25+00:00	2023-04-12T13:40:36+00:00
Envfile
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Clustername	rostam	rostam
Datetime	2023-03-10T03:27:49.135034-06:00	2023-04-12T08:50:34.167277-05:00
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	=

Info

Property	Before	After
HPX Commit	6b6e1e7	95f5b31
HPX Datetime	2023-03-06T15:59:25+00:00	2023-04-12T13:40:36+00:00
Envfile
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Clustername	rostam	rostam
Datetime	2023-03-10T03:28:21.991297-06:00	2023-04-12T08:51:06.050512-05:00
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR	PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR	SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add	(=)	(=)	=
Stream Benchmark - Scale	(=)	(=)	(=)
Stream Benchmark - Triad	(=)	(=)	(=)
Stream Benchmark - Copy	(=)	(=)	(=)

Info

Property	Before	After
HPX Commit	6b6e1e7	95f5b31
HPX Datetime	2023-03-06T15:59:25+00:00	2023-04-12T13:40:36+00:00
Envfile
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Clustername	rostam	rostam
Datetime	2023-03-10T03:28:29.145749-06:00	2023-04-12T08:51:13.218686-05:00
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (≤5%)
++/--	Large performance improvement/degradation (≤10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

[hkaiser]

Very nice! Thanks a lot! Could you please fix the clang-format issues? Otherwise LGTM.

[hkaiser]

LGTM, thanks!

[hkaiser]

@Pansysk75 We now could revert the change here e427e0e. This was introduced to ignore errors when running the segmented algorithm tests.

[Pansysk75]

@Pansysk75 We now could revert the change here e427e0e. This was introduced to ignore errors when running the segmented algorithm tests.

I saw some "Timeout" failures on some segmented algorithms on some past CircleCI runs. This fix does not address those failures. For example: https://app.circleci.com/pipelines/github/STEllAR-GROUP/hpx/14417/workflows/69d7cda3-1ae3-4492-b881-a39d963dd6b5/jobs/340881/tests

I would like to try fixing that as well, but I'm not sure how to approach that issue, or what its cause might be. The CircleCI error message is not very informative.
Well... there is also a 2Gb debug-log.txt, which is saved as an artifact, but I haven't gotten around to trying to parse that yet.

Let me know if you have any input on that.

[Pansysk75]

Then there is also tests.unit.modules.runtime_components.distributed.tcp.migrate_polymorphic_component failing.
I'll use this PR as an opportunity to look into that as well.

[hkaiser]

Then there is also tests.unit.modules.runtime_components.distributed.tcp.migrate_polymorphic_component failing. I'll use this PR as an opportunity to look into that as well.

I appreciate that. Let's do this on a separate PR, however.

[hkaiser]

Well... there is also a 2Gb debug-log.txt, which is saved as an artifact, but I haven't gotten around to trying to parse that yet.

Short of reproducing this locally, the log file is all we have.

[hkaiser]

@Pansysk75 While this fixes one issue, it seems that there are more problems. Should we go ahead with merging this PR anyways?

[Pansysk75]

@Pansysk75 While this fixes one issue, it seems that there are more problems. Should we go ahead with merging this PR anyways?

@hkaiser I agree, let's merge this PR, since I don't have any insight on the "Timeout" issue for the time beign.

[hkaiser]

bors merge

[bors]

Build succeeded:

• Bors