Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making sure serialize_buffer properly destroys buffer, if needed. #6368

Merged
merged 1 commit into from
Oct 28, 2023

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Oct 16, 2023

Fixes #6366

@codacy-production
Copy link

codacy-production bot commented Oct 16, 2023

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.03% 65.35%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (103a7b8) 190583 162311 85.17%
Head commit (c62a6ea) 190573 (-10) 162243 (-68) 85.13% (-0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6368) 101 66 65.35%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@hkaiser hkaiser force-pushed the fixing_6366 branch 8 times, most recently from e97fcfe to dceeeed Compare October 17, 2023 16:50
@hkaiser
Copy link
Member Author

hkaiser commented Oct 23, 2023

retest lsu

@hkaiser
Copy link
Member Author

hkaiser commented Oct 28, 2023

bors merge

bors bot pushed a commit that referenced this pull request Oct 28, 2023
6368: Making sure serialize_buffer properly destroys buffer, if needed. r=hkaiser a=hkaiser

Fixes #6366


6371: Fix jacobi omp examples. r=hkaiser a=rtohid

Makes sure the `HPX_APPLICATION_STRING` is set correctly for non-hpx targets in Jacobi examples when `HPX_WITH_EXAMPLES_OPENMP=ON`.

- We may want to have a testing pipeline for non-hpx examples.
- Thank you `@G-071!`

Co-authored-by: Hartmut Kaiser <hartmut.kaiser@gmail.com>
Co-authored-by: R. Tohid <tohid.rod@gmail.com>
@bors
Copy link

bors bot commented Oct 28, 2023

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

Response status code: 422
{"message":"Changes must be made through a pull request.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@hkaiser hkaiser merged commit 89f342b into master Oct 28, 2023
59 of 75 checks passed
@hkaiser hkaiser deleted the fixing_6366 branch October 28, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

serialize_buffer allocator support needs adjustments
1 participant