Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working around ROCm compiler issue #6406

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Working around ROCm compiler issue #6406

merged 1 commit into from
Jan 10, 2024

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Jan 8, 2024

Fixing #6405

@StellarBot
Copy link

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)??(=)

Info

PropertyBeforeAfter
HPX Datetime2023-05-10T12:07:53+00:002024-01-08T19:43:56+00:00
HPX Commitdcb541580630d7
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Clusternamerostamrostam
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Datetime2023-05-10T14:50:18.616050-05:002024-01-08T13:49:52.757388-06:00
Envfile

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch(=)

Info

PropertyBeforeAfter
HPX Datetime2023-05-10T12:07:53+00:002024-01-08T19:43:56+00:00
HPX Commitdcb541580630d7
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Clusternamerostamrostam
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Datetime2023-05-10T14:52:35.047119-05:002024-01-08T13:52:07.106801-06:00
Envfile

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add(=)(=)(=)
Stream Benchmark - Scale+(=)(=)
Stream Benchmark - Triad(=)(=)(=)
Stream Benchmark - Copy(=)-(=)

Info

PropertyBeforeAfter
HPX Datetime2023-05-10T12:07:53+00:002024-01-08T19:43:56+00:00
HPX Commitdcb541580630d7
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Clusternamerostamrostam
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Datetime2023-05-10T14:52:52.237641-05:002024-01-08T13:52:24.066142-06:00
Envfile

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.03% 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f6f0fcd) 200252 170531 85.16%
Head commit (d0805e1) 190197 (-10055) 161913 (-8618) 85.13% (-0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6406) 1 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@hkaiser
Copy link
Member Author

hkaiser commented Jan 9, 2024

@jholmen Would you be able to check whether this solves the issue you reported?

@jholmen
Copy link

jholmen commented Jan 10, 2024

@jholmen Would you be able to check whether this solves the issue you reported?

This resolved Issue #6405 on my end:

==> Installing hpx-fixing_6405-tte57ciocisuo3mxcgv36bkdccdjo4le [48/48]
==> No binary for hpx-fixing_6405-tte57ciocisuo3mxcgv36bkdccdjo4le found: installing from source
==> No patches needed for hpx
==> hpx: Executing phase: 'cmake'
==> hpx: Executing phase: 'build'
==> hpx: Executing phase: 'install'
==> hpx: Successfully installed hpx-fixing_6405-tte57ciocisuo3mxcgv36bkdccdjo4le
  Stage: 3.04s.  Cmake: 8.93s.  Build: 1m 33.40s.  Install: 10.58s.  Post-install: 5.38s.  Total: 2m 2.29s

Many thanks for the fix, @hkaiser!

@hkaiser
Copy link
Member Author

hkaiser commented Jan 10, 2024

Thanks @jholmen! Merging...

@hkaiser hkaiser merged commit 6db7cad into master Jan 10, 2024
49 of 72 checks passed
@hkaiser hkaiser deleted the fixing_6405 branch January 10, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants