Integrate NVIDIA's Stdexec impl into HPX #6431
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkaiser
reviewed
Feb 3, 2024
isidorostsa
force-pushed
the
include_stdexec
branch
from
8826f04
to
634cb7b
Compare
isidorostsa
force-pushed
the
include_stdexec
branch
from
634cb7b
to
1798cbc
Compare
hkaiser
reviewed
Feb 12, 2024
isidorostsa
force-pushed
the
include_stdexec
branch
from
6ec03fa
to
5b5ac33
Compare
isidorostsa
force-pushed
the
include_stdexec
branch
from
5b5ac33
to
f34103e
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more |
- Completion signatures are a specialization of stdexec::completion_signatures<...> - Senders/Receivers need the is_sender/is_receiver tag - Sender_of<snd, tag> looks for completion signatues (e.g. tag = set_error(std::exception_ptr)) instead of looking for possible set_value(...) specializations
make_env<tag>(val, old_env)
The new calling convention for make_env is:
make_env(old_env, with(tag, val))
…not working. The rest of the tests pass.
isidorostsa
force-pushed
the
include_stdexec
branch
from
9c0318f
to
59b5170
Compare
isidorostsa
force-pushed
the
include_stdexec
branch
from
36bfaf7
to
39cee7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.