Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate NVIDIA's S/R implementation into HPX #6431

Draft
wants to merge 69 commits into
base: master
Choose a base branch
from

Conversation

isidorostsa
Copy link
Contributor

@isidorostsa isidorostsa commented Feb 3, 2024

This PR serves to replace the existing senders/receivers implementation in hpx with the stdexec implementation maintained by NVIDIA.

Big credits to the @pika-org team for their work when solving almost the same problem. This PR is built on top of much of that work.

CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
cmake/FindStdexec.cmake Show resolved Hide resolved
cmake/HPX_SetupStdexec.cmake Outdated Show resolved Hide resolved
cmake/HPX_SetupStdexec.cmake Outdated Show resolved Hide resolved
libs/CMakeLists.txt Outdated Show resolved Hide resolved
libs/core/execution_base/CMakeLists.txt Outdated Show resolved Hide resolved
Copy link

codacy-production bot commented Mar 11, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-85.23% 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (9c53b99) 206733 176197 85.23%
Head commit (a8d51fe) 113511 (-93222) 0 (-176197) 0.00% (-85.23%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6431) 87 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

- Completion signatures are a specialization of stdexec::completion_signatures<...>
- Senders/Receivers need the is_sender/is_receiver tag
- Sender_of<snd, tag> looks for completion signatues (e.g. tag = set_error(std::exception_ptr)) instead of looking for possible set_value(...) specializations
                     make_env<tag>(val, old_env)
The new calling convention for make_env is:
                     make_env(old_env, with(tag, val))
@StellarBot
Copy link

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)--

Info

PropertyBeforeAfter
HPX Datetime2024-03-18T14:00:30+00:002024-06-06T16:55:02+00:00
HPX Commitd27ac2ed6af62a
Envfile
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Clusternamerostamrostam
Datetime2024-03-18T09:18:04.949759-05:002024-06-06T12:58:31.957730-05:00
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch=

Info

PropertyBeforeAfter
HPX Datetime2024-03-18T14:00:30+00:002024-06-06T16:55:02+00:00
HPX Commitd27ac2ed6af62a
Envfile
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Clusternamerostamrostam
Datetime2024-03-18T09:19:53.062988-05:002024-06-06T13:00:17.332364-05:00
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add(=)(=)(=)
Stream Benchmark - Scale(=)(=)(=)
Stream Benchmark - Triad=(=)(=)
Stream Benchmark - Copy(=)==

Info

PropertyBeforeAfter
HPX Datetime2024-03-18T14:00:30+00:002024-06-06T16:55:02+00:00
HPX Commitd27ac2ed6af62a
Envfile
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Clusternamerostamrostam
Datetime2024-03-18T09:20:13.002391-05:002024-06-06T13:00:34.027301-05:00
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@hkaiser
Copy link
Member

hkaiser commented Jun 12, 2024

@isidorostsa just in case you were wondering... the Windows tests all fail with a segmentation fault (error code 0xc0000005)

@isidorostsa
Copy link
Contributor Author

@isidorostsa just in case you were wondering... the Windows tests all fail with a segmentation fault (error code 0xc0000005)

Interestingly it's using c++17 too

@isidorostsa
Copy link
Contributor Author

@hkaiser Should I rebase on top of #6507?

Copy link

codacy-production bot commented Jul 2, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-85.23% 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (9c53b99) 206733 176197 85.23%
Head commit (6a7c2ff) 122668 (-84065) 0 (-176197) 0.00% (-85.23%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6431) 120 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@isidorostsa isidorostsa force-pushed the include_stdexec branch 3 times, most recently from 098bef7 to 980513d Compare July 5, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants