-
-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate NVIDIA's S/R implementation into HPX #6431
base: master
Are you sure you want to change the base?
Conversation
8826f04
to
634cb7b
Compare
634cb7b
to
1798cbc
Compare
6ec03fa
to
5b5ac33
Compare
5b5ac33
to
f34103e
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more |
- Completion signatures are a specialization of stdexec::completion_signatures<...> - Senders/Receivers need the is_sender/is_receiver tag - Sender_of<snd, tag> looks for completion signatues (e.g. tag = set_error(std::exception_ptr)) instead of looking for possible set_value(...) specializations
make_env<tag>(val, old_env) The new calling convention for make_env is: make_env(old_env, with(tag, val))
…not working. The rest of the tests pass.
9c0318f
to
59b5170
Compare
36bfaf7
to
39cee7b
Compare
Performance test reportHPX PerformanceComparison
Info
Comparison
Info
Comparison
Info
Explanation of Symbols
|
7140b85
to
0aa25e4
Compare
@isidorostsa just in case you were wondering... the Windows tests all fail with a segmentation fault (error code |
Interestingly it's using c++17 too |
857dd15
to
12db755
Compare
79e6157
to
f97104d
Compare
1e41926
to
93f76b1
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences🚀 Don’t miss a bit, follow what’s new on Codacy. Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
098bef7
to
980513d
Compare
980513d
to
e063614
Compare
This PR serves to replace the existing senders/receivers implementation in hpx with the stdexec implementation maintained by NVIDIA.
Big credits to the @pika-org team for their work when solving almost the same problem. This PR is built on top of much of that work.