Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing binary filter test target names #6476

Merged

Conversation

m-diers
Copy link
Contributor

@m-diers m-diers commented Apr 25, 2024

Not unique target names in the tests of binary_filter which leads to build errors when switching on the different filter at the same time, e.g. with

          -DHPX_WITH_COMPRESSION_BZIP2=ON \
          -DHPX_WITH_COMPRESSION_SNAPPY=ON \
          -DHPX_WITH_COMPRESSION_ZLIB=ON \
          -DHPX_WITH_TESTS=ON \

Proposed Changes

  • unique target names for binary_filter tests

Checklist

Replaced the non unique copy-paste name with the unique names of the different binary filter in the build config files.

@m-diers m-diers requested a review from hkaiser as a code owner April 25, 2024 07:01
@jenkins-cscs
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link

codacy-production bot commented Apr 25, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.06%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (2e9ae68) 217975 185525 85.11%
Head commit (6830ce8) 190892 (-27083) 162588 (-22937) 85.17% (+0.06%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6476) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hkaiser hkaiser merged commit e977ecc into STEllAR-GROUP:master Apr 28, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants