Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2 tests on FreeBSD by initializing freebsd_environ #6503

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

yurivict
Copy link
Contributor

@yurivict yurivict commented Jun 2, 2024

No description provided.

@yurivict yurivict requested a review from hkaiser as a code owner June 2, 2024 06:48
@jenkins-cscs
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.12%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3521f71) 222028 188803 85.04%
Head commit (d3bb5b1) 191067 (-30961) 162704 (-26099) 85.16% (+0.12%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6503) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hkaiser hkaiser merged commit 5898e7e into STEllAR-GROUP:master Jun 3, 2024
56 of 57 checks passed
@hkaiser
Copy link
Member

hkaiser commented Jun 3, 2024

Congratulations, your first PR to the HPX repository has just been merged! As a 'thank you' we offer a free STE||AR-Group t-shirt to all of our first-time contributors. If you are interested in receiving one, please get back to me directly so we can set up the delivery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants