New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for HPX 1.7.1 #390
Conversation
Thanks Gregor for looking into this! |
@G-071 I could build Octo-Tiger using Kokkos with HPX 1.7.1 and will do some testing soon. |
@G-071 I think we can merge that pull request. I could run on Perlmutter using HPX 1.7.1. However, for Kokkos there are some build issues and I will open a new ticket. Same for the crashing if Kokkos kernels are enabled. This seems not to related to this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@G-071, Can you explain why this change in options.cpp is required?
Is it just a name change or?
@G-071 Can we merge that to master? I would prefer to move to HPX 1.7.1 because I debug the MPI issues with this branch? |
@diehlpk From my point of view it's ready to be merged, but I'm not the one reviewing it :-) @shibersag Do you have any more questions about this PR? |
@hkaiser Could you please have a look?I really would like to get that to master soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I tested Octo-Tiger on Perlmutter with this branch and everything worked.
This PR adds support for compiling Octo-Tiger with HPX 1.7.1
Changelog:
Build instructions
Caveats:
In its current form, this PR would raise the minimum required HPX version to 1.7.0. However, it should be possible to support older versions with some additional changes regarding the headers and buildscripts.Remaining ToDos:
Update CI testsKeep Jenkins Scripts on 1.6.0 for now until we actually use 1.7.1 in production