Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HPX 1.7.1 #390

Merged
merged 16 commits into from Jan 19, 2022
Merged

Add support for HPX 1.7.1 #390

merged 16 commits into from Jan 19, 2022

Conversation

G-071
Copy link
Member

@G-071 G-071 commented Nov 26, 2021

This PR adds support for compiling Octo-Tiger with HPX 1.7.1

Changelog:

  • Updated HPX headers
  • Splitted options.cpp into a separate library (to avoid cyclical build dependencies)
  • Added more device guards for Kokkos compilation as required

Build instructions

Caveats:

  • Using newer HPX versions requires us to use updated Kokkos and hpx-kokkos versions. Hence, this PR currently still depends on the Kokkos PR containing the updates to the recent hpx API changes.
  • In its current form, this PR would raise the minimum required HPX version to 1.7.0. However, it should be possible to support older versions with some additional changes regarding the headers and buildscripts.

Remaining ToDos:

  • Support older HPX versions?
  • Update CI tests Keep Jenkins Scripts on 1.6.0 for now until we actually use 1.7.1 in production

@hkaiser
Copy link
Member

hkaiser commented Nov 26, 2021

Thanks Gregor for looking into this!

@diehlpk
Copy link
Member

diehlpk commented Nov 30, 2021

@G-071 I could build Octo-Tiger using Kokkos with HPX 1.7.1 and will do some testing soon.

@G-071 G-071 marked this pull request as ready for review December 1, 2021 09:37
@diehlpk
Copy link
Member

diehlpk commented Dec 14, 2021

@G-071 I think we can merge that pull request. I could run on Perlmutter using HPX 1.7.1.

However, for Kokkos there are some build issues and I will open a new ticket.

Same for the crashing if Kokkos kernels are enabled. This seems not to related to this pull request.

Copy link
Contributor

@shibersag shibersag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@G-071, Can you explain why this change in options.cpp is required?
Is it just a name change or?

@diehlpk
Copy link
Member

diehlpk commented Jan 10, 2022

@G-071 Can we merge that to master? I would prefer to move to HPX 1.7.1 because I debug the MPI issues with this branch?

@G-071
Copy link
Member Author

G-071 commented Jan 14, 2022

@diehlpk From my point of view it's ready to be merged, but I'm not the one reviewing it :-)

@shibersag Do you have any more questions about this PR?

@diehlpk
Copy link
Member

diehlpk commented Jan 18, 2022

@hkaiser Could you please have a look?I really would like to get that to master soon.

Copy link
Member

@diehlpk diehlpk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I tested Octo-Tiger on Perlmutter with this branch and everything worked.

@diehlpk diehlpk merged commit 4122044 into master Jan 19, 2022
@diehlpk diehlpk deleted the port-to-hpx-1.7 branch January 19, 2022 17:04
@diehlpk diehlpk restored the port-to-hpx-1.7 branch January 19, 2022 17:04
@G-071 G-071 deleted the port-to-hpx-1.7 branch January 21, 2022 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants