Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing tiling to the with-am reconstruct kernel #407

Merged
merged 2 commits into from Mar 2, 2022
Merged

Add missing tiling to the with-am reconstruct kernel #407

merged 2 commits into from Mar 2, 2022

Conversation

G-071
Copy link
Member

@G-071 G-071 commented Mar 1, 2022

This PR fixes an oversight in #406

In one kernel variant the tiling parameter was still missing (which leads to worse GPU performance).

@G-071 G-071 requested a review from diehlpk March 1, 2022 18:32
@G-071 G-071 enabled auto-merge March 1, 2022 19:00
diehlpk
diehlpk approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@diehlpk diehlpk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@G-071 G-071 merged commit 49a910c into master Mar 2, 2022
@G-071 G-071 deleted the add_hydro_tiling branch March 2, 2022 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diehlpk diehlpk diehlpk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@G-071 @diehlpk