Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print git information during Octo-Tiger startup #445

Merged
merged 1 commit into from May 31, 2023
Merged

Conversation

G-071
Copy link
Member

@G-071 G-071 commented May 30, 2023

This commit adds the functionality to store the current git commit hash (and message) from the source directory during into preprocessor macros during the CMake step. These are in turn printed on stdout during the Octo-Tiger startup, easing reproducibility.

This commit also adds a reproducibility warning if the source directory contained uncommitted changes during the CMake step.

This directly addresses the feature request in #435

This commit adds the functionality to store the current git commit hash
and message from the source directory during the CMake configuration
step into preprocessor macros. These are in turn printed on stdout
during the Octo-Tiger start, easing reproducibility.

This commit also adds a reproducibility warning if the source directory
contained uncommitted changes during the CMake step.

This directly addresses the feature request in #435
@G-071 G-071 requested a review from diehlpk May 30, 2023 23:45
@G-071 G-071 changed the title Print Git information during Octo-Tiger startup Print git information during Octo-Tiger startup May 31, 2023
Copy link
Member

@diehlpk diehlpk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@diehlpk diehlpk merged commit 9d4dff4 into master May 31, 2023
14 checks passed
@diehlpk diehlpk deleted the print_git_commit branch May 31, 2023 16:05
@G-071 G-071 mentioned this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants