Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cppuddle finalize method #449

Merged
merged 2 commits into from Jun 8, 2023
Merged

Add cppuddle finalize method #449

merged 2 commits into from Jun 8, 2023

Conversation

G-071
Copy link
Member

@G-071 G-071 commented Jun 7, 2023

The PR SC-SGS/CPPuddle/pull/21 added a finalize method which should be used as it works best with newer cppuddle versions. Hence, this PR adds it to Octo-Tiger (while keeping compatibility to older cppuddle versions).

@G-071 G-071 requested a review from diehlpk June 7, 2023 15:21
Copy link
Member

@diehlpk diehlpk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@G-071 G-071 enabled auto-merge June 7, 2023 22:02
@G-071 G-071 merged commit aa38039 into master Jun 8, 2023
13 checks passed
@G-071 G-071 deleted the adapt_to_new_cppuddle branch June 8, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants