Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failling tests when installed on python 3.8 or later #1218

Closed
git-kale opened this issue Jul 26, 2020 · 11 comments · Fixed by #1219
Closed

Failling tests when installed on python 3.8 or later #1218

git-kale opened this issue Jul 26, 2020 · 11 comments · Fixed by #1219
Labels
category: @Phylanx Everything related to the @Phylanx python decorator type: compatibility issue type: defect

Comments

@git-kale
Copy link
Contributor

Phylanx can be installed on a python with a version greater than 3.7 but running the most basic tests is throwing error.

Docker: stellargroup/phylanx_base:prerequisites
Phylanx at commit: d48b611bbc5337bc14ba93e4bf3cb
Build cmd: cmake -H/phylanx_src -B/phylanx_src/build -DCMAKE_BUILD_TYPE=Debug -DHPX_DIR=/usr/local/lib/cmake/HPX/ -Dblaze_DIR=/usr/local/share/blaze/cmake/ -Dpybind11_DIR=/usr/local/share/cmake/pybind11/

Test Case:
https://github.com/STEllAR-GROUP/phylanx/blob/ce34d25e7550d04533d79fff96153f7d9c476953/tests/regressions/python/832_performance_data.py

Error generated:
https://gist.github.com/git-kale/3d2eecda353df11a0d10efe5953850f2

@git-kale git-kale changed the title installation error with python 3.8 and later Failling tests when installed on python 3.8 or later Jul 26, 2020
@hkaiser
Copy link
Member

hkaiser commented Jul 27, 2020

@rtohid Would you have the time to look into this? From what I can see this is caused by some changes in the AST introduced with Python 3.8.

@rtohid
Copy link
Contributor

rtohid commented Jul 27, 2020

@hkaiser, you are right, ast.Constant was added in 3.6.
@git-kale #1219 should resolve the issue. Please let me know if the issue persisted.

@git-kale
Copy link
Contributor Author

@rtohid
I changed the files in system according to commit : 0a1970cc1500f73956f482fd95bd780b06462f01
And a new error has popped: https://gist.github.com/git-kale/85fae9e96dc66301ef648bf1eaf231fd

rtohid added a commit that referenced this issue Jul 28, 2020
@rtohid
Copy link
Contributor

rtohid commented Jul 28, 2020

@git-kale, hope this works.

@git-kale
Copy link
Contributor Author

@rtohid

AttributeError: 'PhySL' object has no attribute '_<data-type>'
FATAL: exception not rethrown

data-type=['bool','float','int','str']

rtohid added a commit that referenced this issue Jul 28, 2020
@rtohid
Copy link
Contributor

rtohid commented Jul 28, 2020

@git-kale, could you please provide the complete error message? Thank you.

@git-kale
Copy link
Contributor Author

@rtohid
Copy link
Contributor

rtohid commented Jul 28, 2020

@git-kale, thank you. It's a bit strange, #1219 adds _Constant and should've prevented this issue. Let's see how CI build goes. Meanwhile, you may want to double check and make sure that you do have PhySL._Constant in the module getting loaded.

@rtohid
Copy link
Contributor

rtohid commented Jul 28, 2020

@git-kale, can you please make sure the changes are reflected to the module you load during program execution?

@git-kale
Copy link
Contributor Author

Okay, I'll check that and will inform you tomorrow

@git-kale
Copy link
Contributor Author

git-kale commented Aug 1, 2020

@rtohid https://gist.github.com/git-kale/9579c7e649d3c4f742433e467b943f8d This is the debug log generated after adding the folowing lines.

from phylanx import PhylanxSession      
PhylanxSession.config(PhylanxSession.cfg + ["--hpx:debug-hpx-log=file"])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: @Phylanx Everything related to the @Phylanx python decorator type: compatibility issue type: defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants