Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working on distributed LRA implementation #994

Merged
merged 11 commits into from Jul 27, 2019

Conversation

@hkaiser
Copy link
Member

commented Jun 27, 2019

  • added annotation support to primitive_argument_type
  • added annotation_operation primitive
  • factored out common code for transpose and dot
  • added distributed transpose_d and dot_d primitives
  • added num_localities primitive
  • added distributed LRA example

@hkaiser hkaiser added this to the 0.0.1 milestone Jun 27, 2019

@hkaiser hkaiser force-pushed the distributed_lra branch from 4200255 to 4d717f6 Jun 27, 2019

@hkaiser hkaiser force-pushed the distributed_lra branch 5 times, most recently from e11ac6d to 7009fb3 Jul 8, 2019

hkaiser added some commits Jul 5, 2019

Working on distributed LRA implementation
- added annotation support to primitive_argument_type
- added annotation_operation primitive
- factored out common code for transpose and dot
- added distributed transpose_d and dot_d primitives
- added num_localities primitive
- added distributed LRA example
Simplify annotation syntax
- added annotation_d primitive for adding distributed (locality specific)
  annotations
- adding missing distributed 3d transposition operations
Distributed vector/vector dot product implemented
- adding distributed_vector facility
- adding locality annotations, more tiling annotation facilities
- adapting transposition to new facilities

@hkaiser hkaiser force-pushed the distributed_lra branch 2 times, most recently from 1851309 to 8e46ae8 Jul 15, 2019

@hkaiser

This comment has been minimized.

Copy link
Member Author

commented Jul 16, 2019

@stevenrbrandt would you have the time to have a look at the failure generated by the help-check step (https://circleci.com/gh/STEllAR-GROUP/phylanx/28480), please? The help strings that the tool complains about look correct to me (see https://github.com/STEllAR-GROUP/phylanx/blob/distributed_lra/src/execution_tree/primitives/annotate_primitive.cpp#L40, for instance).

@hkaiser hkaiser force-pushed the distributed_lra branch from 8e46ae8 to 13fb655 Jul 16, 2019

@stevenrbrandt

This comment has been minimized.

Copy link
Member

commented Jul 18, 2019

@hkaiser The error message is telling you that the help message doesn't have a "Returns" section (which is required). See ./src/plugins/arithmetics/cumsum.cpp (for an example) around line 40.

@hkaiser

This comment has been minimized.

Copy link
Member Author

commented Jul 19, 2019

The error message is telling you that the help message doesn't have a "Returns" section (which is required). See ./src/plugins/arithmetics/cumsum.cpp (for an example) around line 40.

@stevenrbrandt the relevant error message does have a Returns: section, see: https://github.com/STEllAR-GROUP/phylanx/blob/distributed_lra/src/execution_tree/primitives/annotate_primitive.cpp#L48.

@hkaiser

This comment has been minimized.

Copy link
Member Author

commented Jul 20, 2019

@stevenrbrandt

This comment has been minimized.

Copy link
Member

commented Jul 23, 2019

Something is very strange here... still working on it.

@stevenrbrandt

This comment has been minimized.

Copy link
Member

commented Jul 23, 2019

The check_help.py script has been broken since PhylanxSession was added. A number of primitives were not being validated and so there are now tons of non-conforming help strings.

However, I think what you need to get you through your current problem is the following change:

diff --git a/tools/check_help/check_help.py b/tools/check_help/check_help.py
index 6088cf49..12472cff 100644
--- a/tools/check_help/check_help.py
+++ b/tools/check_help/check_help.py
@@ -51,6 +51,8 @@ for p in all:

         # The the phylanx help string for the function
         h = phyhelpex(n)
+        if "No help available" in h:
+            h = phyhelpex(p)

         # Strip off leading whitespace
         g = re.search(r'^([ \t]*)Args:', h, re.MULTILINE)

@hkaiser hkaiser marked this pull request as ready for review Jul 25, 2019

@hkaiser hkaiser merged commit 54274cb into master Jul 27, 2019

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
build_and_test_phylanx Workflow: build_and_test_phylanx
Details

@hkaiser hkaiser deleted the distributed_lra branch Jul 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.