Control topic handling. #167
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dan Nixon <dan@dan-nixon.com>
Co-authored-by: Dan Nixon <dan@dan-nixon.com>
This is so that there is less ambiguity when the `control_topic` command line argument is added later.
In the case the control topic is not provided, the tool should use the default behaviour.
Uses the Unix epoch timestamp milliseconds as the filenames. This could potentially be problematic if two (or more) runs are started less than a millisecond apart. Should look for a better way of generating filename UIDs.
DanNixon
requested changes
May 23, 2024
DanNixon
requested changes
Jun 6, 2024
trace-archiver-hdf5/src/main.rs
Outdated
| debug!("New run start."); | ||
| // Start recording trace data to file. | ||
| if file.is_none() { | ||
| let filename = generate_filename(msg.timestamp()); |
There was a problem hiding this comment.
The timestamp from the run start message should be used here, not the Kafka timestamp.
Co-authored-by: Dan Nixon <dan@dan-nixon.com>
Co-authored-by: Dan Nixon <dan@dan-nixon.com>
This is to combat the issue where the `file` command line argument was required regardless of whether it was actually needed (for example if a control topic is provided then the files are just saved under the timestamp).
Henry-Denny
force-pushed
the
control-topic-handling
branch
from
ac35b62
to
15ad6bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is a continuation of #165 and aims to close #113. It gives the
trace-archiver-hdf5the ability to consume a control topic, and use this to handle when to start and stop the recording of trace data to an HDF file.