Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lsm6dso: Example perhaps uses wrong function #142

Closed
capiman opened this issue Oct 7, 2021 · 2 comments
Closed

lsm6dso: Example perhaps uses wrong function #142

capiman opened this issue Oct 7, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@capiman
Copy link

capiman commented Oct 7, 2021

STMems_Standard_C_drivers/lsm6dso32_STdC/examples/lsm6dso32_self_test.c

Line 340 in 90f9bf1

lsm6dso32_xl_data_rate_set(&dev_ctx, LSM6DSO32_GY_ODR_OFF);

/* Disable sensor. */
lsm6dso32_xl_data_rate_set(&dev_ctx, LSM6DSO32_GY_ODR_OFF);

Must it be

/* Disable sensor. */
lsm6dso32_gy_data_rate_set(&dev_ctx, LSM6DSO32_GY_ODR_OFF);

?

Otherwise my compiler tells me LSM6DSO32_GY_ODR_OFF does not fit to type of lsm6dso32_xl_data_rate_set...
@capiman capiman added the bug Something isn't working label Oct 7, 2021
@avisconti
Copy link
Contributor

STMems_Standard_C_drivers/lsm6dso32_STdC/examples/lsm6dso32_self_test.c

Line 340 in 90f9bf1

lsm6dso32_xl_data_rate_set(&dev_ctx, LSM6DSO32_GY_ODR_OFF);

/* Disable sensor. */ lsm6dso32_xl_data_rate_set(&dev_ctx, LSM6DSO32_GY_ODR_OFF);

Must it be

/* Disable sensor. */ lsm6dso32_gy_data_rate_set(&dev_ctx, LSM6DSO32_GY_ODR_OFF);

?

Otherwise my compiler tells me LSM6DSO32_GY_ODR_OFF does not fit to type of lsm6dso32_xl_data_rate_set...

Yes sure, it's a typo.
Can you submit a PR mentioning this issue (i.e. #142) in the commit message? Thanks!

capiman pushed a commit to capiman/STMems_Standard_C_drivers that referenced this issue Oct 7, 2021
LSM6DSO32_GY_ODR_OFF does not fit to type of lsm6dso32_xl_data_rate_s…
c850498 
…et (STMicroelectronics#142)
This was referenced Oct 7, 2021
Closed
Closed
@capiman
Copy link
Author

capiman commented Oct 7, 2021

#144

@capiman capiman mentioned this issue Oct 12, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@avisconti @capiman