Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

needs initial values even though optional #40

Merged
merged 1 commit into from Apr 24, 2019
Merged

needs initial values even though optional #40

merged 1 commit into from Apr 24, 2019

Conversation

tnmt
Copy link
Contributor

@tnmt tnmt commented Apr 19, 2019

hi, @hfm

I met below error, and I don't set these parameters.

Error: Evaluation Error: Error while evaluating a Function Call, Class[Stns::Client]:
  expects a value for parameter 'auth_token'
  expects a value for parameter 'wrapper_path'
  expects a value for parameter 'chain_ssh_wrapper'
  expects a value for parameter 'request_timeout'
  expects a value for parameter 'request_retry'
  expects a value for parameter 'uid_shift'
  expects a value for parameter 'gid_shift'

this is example that using stns::client and stns::server seems same.

Do you think this patch is correct?

@hfm
Copy link
Member

hfm commented Apr 20, 2019

Yes, it's correct for Puppet 4.
I'll fix CI failures before merge this PR.

@hfm hfm self-assigned this Apr 20, 2019
@hfm
Copy link
Member

hfm commented Apr 24, 2019

@tnmt Sorry late response. I fixed CI on #41 . Please update this branch.

@tnmt
Copy link
Contributor Author

tnmt commented Apr 24, 2019

Thank you.

I rebased my commit. Please review again.

@hfm hfm merged commit a034396 into STNS:master Apr 24, 2019
@tnmt tnmt deleted the needs-initial-values branch April 24, 2019 13:32
@hfm
Copy link
Member

hfm commented Apr 24, 2019

Thanks for your patch! I released https://forge.puppet.com/hfm/stns/3.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants