Port-Group speed updates and Interface valid-speeds issue. #67 #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
other pull request: |
2 tasks
kamalkrbh
reviewed
Jul 3, 2024
pyproject.toml
Outdated
| @@ -1,5 +1,5 @@ | |||
| [tool.poetry] | |||
| version = "1.3.15" | |||
| version = "1.3.16" | |||
There was a problem hiding this comment.
@rahul-1475, Version should be +1.
Suggested change
| version = "1.3.16" | |
| version = "1.3.17" |
There was a problem hiding this comment.
changed orca_nw_lib version to 1.3.17
kamalkrbh
reviewed
Jul 3, 2024
orca_nw_lib/portgroup.py
Outdated
| @@ -81,7 +81,7 @@ def get_port_group_members(device_ip: str, group_id): | |||
| op_dict.append(mem_if.__properties__) | |||
| return op_dict | |||
|
|
|||
| def get_port_group_of_interface(device_ip: str, if_name:str): | |||
| def get_port_group_of_interface(device_ip: str, group_id:str): | |||
There was a problem hiding this comment.
@rahul-1475 , The purpose of this function is to know the port group of a given interface. So input parameters has to be interface name instead fix has to be in the body of the function where DB function get_port_group_of_if_from_db should be called.
There was a problem hiding this comment.
- changed code get to use function get_port_group_of_if_from_db to port group name by interface.
- created api to get prot group name by interface
kamalkrbh
requested changes
Jul 3, 2024
kamalkrbh
requested changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67
issue:
If port group speed is set to 25G , all interface in the port-group are updated to have the speed 25G, but the valid speeds and adv-speed set is still 1G and 10G which is not correct.
The correct behaviour would be if port-group speed is updated, after receving the port-group update via gNMI subscription make an additional gnmi get to update the valid_speeds field for interface at sonic-port:sonic-port/PORT/PORT_LIST={interface_name}.
Write test case for above.
Fixes: