Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Node 18 the minimum Node Version #620

Merged
merged 34 commits into from
Apr 9, 2024
Merged

Make Node 18 the minimum Node Version #620

merged 34 commits into from
Apr 9, 2024

Conversation

philfuster
Copy link
Contributor

@philfuster philfuster commented Apr 3, 2024 •
edited
Loading

Summary

  • Remove support for Node 16
  • Make Node 18 the minimum Node version
  • Add Node 20 to the CI support matrix
  • Upgrade Docusaurus to V3.2.1. V2 does not support Node 18+

@philfuster
Change package.json engines field to point to node version 20 and up.
cf0472c
@philfuster
Update documentation to reference node version 20
c5b7e98
@philfuster
deleted node modules and re-installed dependencies with npm instead o…
09a8668 
…f pnpm.

Thus updating the package-lock.json.
@philfuster
update babelrc.js to reference node 20.
85505df
@philfuster
update ci.yaml to use node 20. Updated the matrix for the test action…
5bff4ab 
… to use 181and 20.
@philfuster
updated gh-pages.yml to reference node version 20 instead of 16.
7b575eb
@philfuster
Updated node version minimum to 18 in package.json.
e3dd11c 
Ran `npm install` to update package-lock.json.
@philfuster
Updated babelrc to target node 18.
06df42a
@philfuster
Update ci and gh-pages to run using node 18.
147722d
@philfuster
Update version to 2.0.0
fcc9f38
@philfuster
Update changelog
6b50173
@philfuster
upgrade package.json dependencies according to the docusaurus upgrade…
cbb21d4 
… to v3 guide.

Modified tsconfig to reference the new base config from docusaurus.
@philfuster
Upgrade dependencies.
4d66717
@philfuster
update tsconfig to include ts config files.
47d0479 
Changed docusaurus config to a typescript file.
@philfuster
Remove explicit import of React. no longer needed because of React 18…
8acb560 
… automatic JSX runtime.
@philfuster
Update admonitions according to the upgrade to v3 notes - [docusaurus…
4229231 
… v3 upgrade | admonition warning](https://docusaurus.io/docs/migration/v3#admonition-warning)
@philfuster
prettier on tsconfig.json.
26c746e
@philfuster
update mvom packages release version in pnpm-lock.json
bbe447f
@philfuster
Updated Docusaurus to version 3.2 because version 3 depended on an un…
c9c46bd 
…-maintained react-json-view library that was causing an issue with using Node 18. This was fixed before 3.2 but I figured might as well just update to the latest minor version.
@philfuster
Fix broken links and anchors.
fc586de
@philfuster philfuster marked this pull request as ready for review April 4, 2024 18:51
@kthompson23 kthompson23 requested review from shawnmcknight and removed request for kthompson23 April 4, 2024 20:30
@shawnmcknight
Copy link
Member

I was about to comment that I didn't think we should bump the requirement to Node 20 since 18 is still on active LTS. However, it looks like that was the change that was made to make Node 18 the release. The PR title doesn't reflect that though, so I think that needs to be changed.

@shawnmcknight
Copy link
Member

The Github workflows should be updated to use later action versions to avoid these messages in the CI logs:
image

@philfuster philfuster changed the title Upgrade to node 20 remove node 16 Make Node 18 the minimum Node Version Apr 5, 2024
@philfuster
Copy link
Contributor Author

The Github workflows should be updated to use later action versions to avoid these messages in the CI logs: image

@shawnmcknight Thank you, I was unaware of that. Good to know. I have made that update.

shawnmcknight
shawnmcknight requested changes Apr 5, 2024
View reviewed changes
Copy link
Member

@shawnmcknight shawnmcknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. I had a few notes of things I found during my review. Let me know if you have any questions!

CHANGELOG.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
website/docs/03 - Schema/01 - Basics.md Outdated Show resolved Hide resolved
website/docs/04 - Model/06 - Querying/02 - Query Operators.md Outdated Show resolved Hide resolved
website/docs/04 - Model/06 - Querying/02 - Query Operators.md Show resolved Hide resolved
website/docs/04 - Model/07 - Advanced Topics/02 - Projection.md Outdated Show resolved Hide resolved
website/docs/01 - Introduction/01 - What is MVOM.md Outdated Show resolved Hide resolved
website/docusaurus.config.ts Outdated Show resolved Hide resolved
website/package.json Outdated Show resolved Hide resolved
@philfuster
Updated CHANGELOG.
ee410d3 
Changed release to 3.0.0 because of breaking the changes.
Removed the reference to the new documenation updates. The
documentation be updated in separate PR when this version is ready for
release.
@philfuster
Revert package.json version change. Shouldn't be updated till new rel…
ca2a05f 
…ease is being prepared.
@philfuster
Change remaining caution admonitions to warning.
5d8b98a 
Remove admonition description override on existing warning admonitions.
Default warning text will suffice.
@philfuster
revert updating documentation version in docusaurus.config.ts. Goes i…
50b3907 
…n separate PR.
@philfuster
revert update to node version in the docs. Goes in separate PR.
1bd5ffc
@philfuster
update to docusarus v3.2.1.
f8fbc60 
Update change log to reflect that.
shawnmcknight
shawnmcknight reviewed Apr 8, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
website/docs/01 - Introduction/01 - What is MVOM.md Outdated Show resolved Hide resolved
shawnmcknight
shawnmcknight requested changes Apr 8, 2024
View reviewed changes
Copy link
Member

@shawnmcknight shawnmcknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there might have been some confusion about what I meant regarding the changelog. Additionally, the PR for the docs changes should be submitted now as well.

shawnmcknight
shawnmcknight requested changes Apr 9, 2024
View reviewed changes
Copy link
Member

@shawnmcknight shawnmcknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just the one final note about getting the section headings back in place in the changelog.

CHANGELOG.md Show resolved Hide resolved
shawnmcknight
shawnmcknight approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@shawnmcknight shawnmcknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shawnmcknight shawnmcknight merged commit 6827f3d into main Apr 9, 2024
4 checks passed
@shawnmcknight shawnmcknight deleted the upgrade_to_node_20_remove_node_16 branch April 9, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnmcknight shawnmcknight shawnmcknight approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@philfuster @shawnmcknight