Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporary fix (because it's an hack) of issue #837 #840

Merged

Conversation

MathiasPaulin
Copy link
Contributor

This is a quick fix for issue #837.
Point cloud are now easily pickable.
resolve #837.

@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #840 (a1e495a) into release-candidate (fd7f88f) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                  Coverage Diff                  @@
##           release-candidate     #840      +/-   ##
=====================================================
- Coverage              26.42%   26.41%   -0.01%     
=====================================================
  Files                    321      321              
  Lines                  21406    21410       +4     
=====================================================
  Hits                    5656     5656              
- Misses                 15750    15754       +4     
Impacted Files Coverage Δ
src/Engine/Rendering/Renderer.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c916f07...a1e495a. Read the comment docs.

@nmellado
Copy link
Contributor

@chemseddinehimeur is it fix working for you ?

@nmellado
Copy link
Contributor

nmellado commented Jan 5, 2022

@chemseddinehimeur is it working for you ? I would like to merge this PR.

@chemseddinehimeur
Copy link

I could not get it to compile for some reason

Install the project...
-- Install configuration: "Release"
[ 87%] Completed 'OpenMesh'
[ 87%] Built target OpenMesh
gmake: *** [Makefile:103: all] Error 2
CMake Error at cmake/ExternalFunc.cmake:81 (message):
  Cmake build step failed.
Call Stack (most recent call first):
  src/Core/CMakeLists.txt:34 (add_external_folder)


-- Configuring incomplete, errors occurred!
See also "/ssd/chimeur/Raduim/Radium-Engine/build-release/CMakeFiles/CMakeOutput.log".
See also "/ssd/chimeur/Raduim/Radium-Engine/build-release/CMakeFiles/CMakeError.log".
make: *** No rule to make target 'install'.  Stop.

I even deleted everything and started fresh, it wouldn't compile.

@MathiasPaulin
Copy link
Contributor Author

I even deleted everything and started fresh, it wouldn't compile.

Very strange your build error. Nothing changed on this. Only two files were modified. Do you use the procedure described un the doc (Building and installing Radium dependencies once for all) to build and install your Radium environment ?

do you have a more detailed error report ?
Send it on private channel.

@chemseddinehimeur
Copy link

Works fine @nmellado @MathiasPaulin

@nmellado nmellado merged commit a451320 into STORM-IRIT:release-candidate Jan 7, 2022
@MathiasPaulin MathiasPaulin deleted the temporaryfix_#837 branch January 19, 2022 12:08
ntsh-oni pushed a commit to ntsh-oni/Radium-Engine that referenced this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants