Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not mutate layouts prop (#1063) #1064

Merged
merged 1 commit into from
Nov 20, 2019
Merged

Do not mutate layouts prop (#1063) #1064

merged 1 commit into from
Nov 20, 2019

Conversation

darekkay
Copy link
Contributor

@darekkay darekkay commented Nov 1, 2019 •
edited
Loading

Mutating the layout props is discouraged in React. It may crash the application when the immer library is being used.

Fixes: #1063

@darekkay darekkay mentioned this pull request Nov 1, 2019
Closed
n1ghtmare
n1ghtmare approved these changes Nov 7, 2019
View reviewed changes
Copy link
Collaborator

@n1ghtmare n1ghtmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@STRML STRML merged commit e3e0e82 into react-grid-layout:master Nov 20, 2019
@STRML
Copy link
Collaborator

STRML commented Nov 20, 2019

Thanks!

@darekkay darekkay deleted the fix/mutating-props branch November 20, 2019 19:52
@misha-panyushkin
Copy link

@STRML is there a chance to get the new release in the nearest future?

@dmitrif
Copy link

dmitrif commented Feb 11, 2020

Any update on the release, @STRML ? Thank you.

@STRML
Copy link
Collaborator

STRML commented Feb 25, 2020

Releasing now in 0.18.0. Just finishing up the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n1ghtmare n1ghtmare n1ghtmare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ResponsiveReactGridLayout mutates props
5 participants
@darekkay @STRML @misha-panyushkin @dmitrif @n1ghtmare