This things here do um Test stuffs moar better

[pookmish]

READY FOR REVIEW

Summary

• Allow for different codeception test execution
• Target only the cardinal service profile for codeception testing at this time.

Need Review By (Date)

-4/8

Urgency

• medium

Steps to Test

1. review circleci tests
2. optionally checkout this branch and run blt codeception cardinal_service_profile to test against a local site.

See Also

• PR Checklist

[sherakama]

[jbickar]

I guess I'm going to have to be the one to set up Lando on this application if I want to use it to test locally.

[pookmish]

@jbickar multisite lando requires more than just those configs. see https://github.com/SU-HSDO/suhumsci/blob/develop/lando/default.lando.yml that Shea put togeather

[sherakama]

@jbickar multisite lando requires more than just those configs. see https://github.com/SU-HSDO/suhumsci/blob/develop/lando/default.lando.yml that Shea put togeather

Yeah, that might be handy. Thanks for the reminder.

[jbickar]

Agreed that multisite lando config is moar better (and I'll add that), but it should work on the default site with only one configured, correct?

Which site in the multisite does blt codeception cardinal_service_profile run on?

[pookmish]

Which site in the multisite does blt codeception cardinal_service_profile run on?

It runs on the URL that is configured in tests/codeception/acceptance.suite.yml. That file is generated at the beginning of the blt codeception command if it doesn't exist. The tests are for the cardinal_service_profile so if you wish to test on the default directory, you'd have to make a few changes to the settings on that directory and then install the profile there.

[jbickar]

optionally checkout this branch and run blt codeception cardinal_service_profile to test against a local site.

That is the suite I am trying to run, per the testing instructions.

It runs on the URL that is configured in tests/codeception/acceptance.suite.yml. That file is generated at the beginning of the blt codeception command if it doesn't exist. The tests are for the cardinal_service_profile so if you wish to test on the default directory, you'd have to make a few changes to the settings on that directory and then install the profile there.

I am not seeing in tests/codeception/acceptance.suite.yml where it is defining a site within the multisite to run on. I see uri: 'appserver/' passed to drush.

lando blt codeception cardinal_service_profile
We strive to give you the best tools for development.
You can really help us improve by sharing anonymous performance and usage data.

 Do you want to help us make this tool even better? (y/n) n
Ok, no data will be tracked and reported.
We take privacy seriously.
[Filesystem\FilesystemStack] mkdir ["/app/tests/codeception/acceptance/20200402-1613"]
[Remote\Rsync] Running rsync --recursive /app/docroot/profiles/custom/cardinal_service_profile/tests/codeception/acceptance/ /app/tests/codeception/acceptance/20200402-1613
[Remote\Rsync] Done in 0.048s
[Exec] Running vendor/bin/codecept run acceptance --steps --config=tests --html --xml
Codeception PHP Testing Framework v4.1.4
Powered by PHPUnit 7.5.20 by Sebastian Bergmann and contributors.
Running with seed: 


In DrupalKernel.php line 377:
                                                                    
  [Symfony\Component\HttpKernel\Exception\BadRequestHttpException]  

[pookmish]

Drupal docroot
Testable domain
Multisite domain
Browser test url
Path to drush

All of these values get generated by your local.blt.yml settings.

[jbickar]

OK, I'm having trouble getting this up and running locally with Lando, even with the multisite config and adding a uri in blt/local.blt.yml. I will grab some time with you and @sherakama to troubleshoot.

[jbickar]

Lando config

blt/local.blt.yml:

# Override any settings as necessary by copying to local.blt.yml
project:
 local:
   protocol: http
   hostname: appserver/
   uri: https://cardinalservice.lndo.site
drupal:
  db:
    username: drupal
    password: drupal
    host: database
tests:
  selenium:
    url: http://chromedriver:4444/wd/hub
behat:
  selenium:
    url: http://chromedriver:4444/wd/hub
  chromedriver:
    url: http://chromedriver

[jbickar]

This things here do um Test stuffs moar better

OK, @pookmish and I spent about an hour hammering on this today. Here are my notes; additional PR for Lando forthcoming.

General Notes

• lando blt blt:init:settings generates blt/local.blt.yml from lando/example.local.blt.yml (is that right?)
• tests/codeception/acceptance.suite.yml gets generated by BLT based on values in blt/local.blt.yml
• Need to uninstall simplesamlphp_auth on local for running codeception tests
• When codeception fails, re-runs puke on some of the files in the root artifacts directory
• You can pass --site=cardinalservice to lando blt drupal:install

TODOs

• Modify lando/example.local.blt.yml (JB)
• Add a lando/local.sites.php file and copy it into the init-lando composer script (JB)
• Update README for lando (JB)
• Disable healthcheck for lando(JB), e.g.,:

  database:
    type: mysql:5.7
    creds:
      user: drupal
      password: drupal
      database: drupal
    healthcheck:

• Add some logic to codeception integration to handle errors with the artifacts directory (MD)

[pookmish]

FINE I will push the button. 🙄

[sherakama]

ci/circleci: run-codeception-acceptance isn't reporting back as successful?

@jbickar as of 5 minutes ago: lando/lando#1088
Looks like an upcoming release will fix the healthcheck issue.

[sherakama]

WHAT ABOUT THE STALLED CHECK?

[pookmish]

run-codeception-acceptance was removed. i just have to remove it from the repo settings

[sherakama]

Got it. Thanks. I'll hit the... oh.

[pookmish]

Why can't i find where to remove that.... 🤔

[pookmish]

nvm. found it