removing properties and fields without paths from cfe #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pookmish
reviewed
Feb 4, 2019
pookmish
reviewed
Feb 4, 2019
stanford_capx.forms.inc
Outdated
| @@ -997,12 +997,22 @@ function stanford_capx_mapper_form_submit($form, $form_state) { | |||
| // If there are properties... | |||
| $properties = @$values['field-mapping'][$entity . "-properties"]; | |||
| if (!empty($properties)) { | |||
| foreach ($properties as $key => $value) { | |||
| if (empty($value)) { | |||
There was a problem hiding this comment.
Suggested change
| if (empty($value)) { | |
| if (empty(array_filter($value))) { |
|
So the form was not removing the property mapping on save but rather, was introducing an empty string? So if I have this right, what happened was:
Is that right? It was the action of trying to remove the mapping that caused the error? |
|
@sherakama yes, you have the scenario correct. |
|
The logic is a little messy. lately ive starting to become a fan of |
|
ok, the properties and fields array are a bit different but this latest version is working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
Needed By (Date)
Urgency
Steps to Test
Affected Projects or Products
Associated Issues and/or People